LaconicNetwork/vega-frontend-monorepo
3
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

chore: improve connect wallet button in deal ticket (#1793)

Browse Source 
* chore: improve connect wallet button in deal ticket

* chore: improve connect wallet button in deal ticket

* chore: improve connect wallet button in deal ticket

Co-authored-by: maciek <maciek@vegaprotocol.io>
This commit is contained in:
macqbat 2022-10-20 08:41:02 +02:00 committed by GitHub
parent 3c0dd55d7c
commit c15765de79
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
apps/trading-e2e/src/integration/trading-deal-ticket.cy.ts
View File

@ -212,11 +212,6 @@ describe('deal ticket validation', { tags: '@smoke' }, () => {
cy.getByTestId('order-connect-wallet').should('exist');
cy.getByTestId(placeOrderBtn).should('not.exist');
cy.getByTestId(errorMessage).should('not.exist');
cy.getByTestId('order-get-vega-wallet').should(
'have.attr',
'href',
'https://github.com/vegaprotocol/vega/releases'
);
});
it('must be able to select order direction - long/short', function () {

36
libs/deal-ticket/src/components/deal-ticket/deal-ticket.tsx
View File

@ -5,7 +5,7 @@ import {
addDecimalsFormatNumber,
removeDecimal,
} from '@vegaprotocol/react-helpers';
import { Button, InputError, Link } from '@vegaprotocol/ui-toolkit';
import { Button, InputError } from '@vegaprotocol/ui-toolkit';
import { TypeSelector } from './type-selector';
import { SideSelector } from './side-selector';
import { DealTicketAmount } from './deal-ticket-amount';
@ -13,11 +13,7 @@ import { TimeInForceSelector } from './time-in-force-selector';
import type { DealTicketMarketFragment } from './__generated___/DealTicket';
import { ExpirySelector } from './expiry-selector';
import type { OrderSubmissionBody } from '@vegaprotocol/wallet';
import {
useVegaWallet,
useVegaWalletDialogStore,
VEGA_WALLET_RELEASE_URL,
} from '@vegaprotocol/wallet';
import { useVegaWallet, useVegaWalletDialogStore } from '@vegaprotocol/wallet';
import { OrderTimeInForce, OrderType } from '@vegaprotocol/types';
import { getDefaultOrder } from '../deal-ticket-validation';
import {
@ -179,25 +175,15 @@ export const DealTicket = ({
)}
</>
) : (
<>
<Button
variant="default"
fill
type="button"
data-testid="order-connect-wallet"
onClick={openVegaWalletDialog}
className="!text-sm !px-1 !py-1"
>
{t('Connect your Vega wallet to trade')}
</Button>
<Link
data-testid="order-get-vega-wallet"
className="block w-full text-center mt-2 text-neutral-500 dark:text-neutral-400"
href={VEGA_WALLET_RELEASE_URL}
>
{t('Get a Vega Wallet')}
</Link>
</>
<Button
variant="default"
fill
type="button"
data-testid="order-connect-wallet"
onClick={openVegaWalletDialog}
>
{t('Connect wallet')}
</Button>
)}
</form>
);