From c15765de792c877a9de60fc476978bdbcb288ad1 Mon Sep 17 00:00:00 2001 From: macqbat <kubat.maciek@gmail.com> Date: Thu, 20 Oct 2022 08:41:02 +0200 Subject: [PATCH] chore: improve connect wallet button in deal ticket (#1793) * chore: improve connect wallet button in deal ticket * chore: improve connect wallet button in deal ticket * chore: improve connect wallet button in deal ticket Co-authored-by: maciek <maciek@vegaprotocol.io> --- .../src/integration/trading-deal-ticket.cy.ts | 5 --- .../components/deal-ticket/deal-ticket.tsx | 36 ++++++------------- 2 files changed, 11 insertions(+), 30 deletions(-) diff --git a/apps/trading-e2e/src/integration/trading-deal-ticket.cy.ts b/apps/trading-e2e/src/integration/trading-deal-ticket.cy.ts index 0c0454e59..932763ff8 100644 --- a/apps/trading-e2e/src/integration/trading-deal-ticket.cy.ts +++ b/apps/trading-e2e/src/integration/trading-deal-ticket.cy.ts @@ -212,11 +212,6 @@ describe('deal ticket validation', { tags: '@smoke' }, () => { cy.getByTestId('order-connect-wallet').should('exist'); cy.getByTestId(placeOrderBtn).should('not.exist'); cy.getByTestId(errorMessage).should('not.exist'); - cy.getByTestId('order-get-vega-wallet').should( - 'have.attr', - 'href', - 'https://github.com/vegaprotocol/vega/releases' - ); }); it('must be able to select order direction - long/short', function () { diff --git a/libs/deal-ticket/src/components/deal-ticket/deal-ticket.tsx b/libs/deal-ticket/src/components/deal-ticket/deal-ticket.tsx index 918d328dd..dcba7b590 100644 --- a/libs/deal-ticket/src/components/deal-ticket/deal-ticket.tsx +++ b/libs/deal-ticket/src/components/deal-ticket/deal-ticket.tsx @@ -5,7 +5,7 @@ import { addDecimalsFormatNumber, removeDecimal, } from '@vegaprotocol/react-helpers'; -import { Button, InputError, Link } from '@vegaprotocol/ui-toolkit'; +import { Button, InputError } from '@vegaprotocol/ui-toolkit'; import { TypeSelector } from './type-selector'; import { SideSelector } from './side-selector'; import { DealTicketAmount } from './deal-ticket-amount'; @@ -13,11 +13,7 @@ import { TimeInForceSelector } from './time-in-force-selector'; import type { DealTicketMarketFragment } from './__generated___/DealTicket'; import { ExpirySelector } from './expiry-selector'; import type { OrderSubmissionBody } from '@vegaprotocol/wallet'; -import { - useVegaWallet, - useVegaWalletDialogStore, - VEGA_WALLET_RELEASE_URL, -} from '@vegaprotocol/wallet'; +import { useVegaWallet, useVegaWalletDialogStore } from '@vegaprotocol/wallet'; import { OrderTimeInForce, OrderType } from '@vegaprotocol/types'; import { getDefaultOrder } from '../deal-ticket-validation'; import { @@ -179,25 +175,15 @@ export const DealTicket = ({ )} </> ) : ( - <> - <Button - variant="default" - fill - type="button" - data-testid="order-connect-wallet" - onClick={openVegaWalletDialog} - className="!text-sm !px-1 !py-1" - > - {t('Connect your Vega wallet to trade')} - </Button> - <Link - data-testid="order-get-vega-wallet" - className="block w-full text-center mt-2 text-neutral-500 dark:text-neutral-400" - href={VEGA_WALLET_RELEASE_URL} - > - {t('Get a Vega Wallet')} - </Link> - </> + <Button + variant="default" + fill + type="button" + data-testid="order-connect-wallet" + onClick={openVegaWalletDialog} + > + {t('Connect wallet')} + </Button> )} </form> );