LaconicNetwork/vega-frontend-monorepo
3
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

feat(governance,proposals,web3): remove use of word "we" in copy (#4034)

Browse Source
This commit is contained in:
Sam Keen 2023-06-06 22:21:17 +01:00 committed by GitHub
parent 473c244d7b
commit 3f01b93159
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
apps/governance/src/i18n/translations/dev.json
View File

@ -116,7 +116,7 @@
"Showing tranches with <{{trancheMinimum}} VEGA, click to hide these tranches": "Showing tranches with ≤{{trancheMinimum}} $VEGA, click to hide these tranches",
"Not showing tranches with <{{trancheMinimum}} VEGA, click to show all tranches": "Not showing tranches with ≤{{trancheMinimum}} $VEGA, click to show all tranches",
"the holder": "the holder",
"We couldn't seem to load your data.": "We couldn't seem to load your data.",
"Your data couldn't be loaded": "Your data couldn't be loaded",
"Vesting VEGA": "Vesting VEGA",
"All the tokens in this tranche are locked and can not be redeemed yet.": "All the tokens in this tranche are locked and can not be redeemed yet.",
"Redeem unlocked VEGA from tranche {{id}}": "Redeem unlocked $VEGA from tranche {{id}}",
@ -728,7 +728,7 @@
"ThisWillSetEnactmentDeadlineTo": "This will set the enactment date to",
"ThisWillSetValidationDeadlineTo": "This will set the validation deadline to",
"Hours": "hours",
"ThisWillAdd2MinutesToAllowTimeToConfirmInWallet": "Note: we add 2 minutes of extra time when you choose the minimum value. This gives you time to confirm the proposal in your wallet.",
"ThisWillAdd2MinutesToAllowTimeToConfirmInWallet": "Note: 2 minutes of extra time are added when you choose the minimum value. This gives you time to confirm the proposal in your wallet.",
"ProposalWillFailIfEnactmentIsEarlierThanVotingDeadline": "Proposal will fail if enactment is earlier than the voting deadline",
"SelectAMarketToChange": "Select a market to change",
"MarketName": "Market name",

2
apps/governance/src/routes/proposals/components/propose/proposal-form-vote-and-enactment-deadline.spec.tsx
View File

@ -146,7 +146,7 @@ describe('Proposal form vote, validation and enactment deadline', () => {
it('should show the correct datetimes', () => {
renderComponent();
// Should be adding 2 mins to the vote deadline as the minimum is set by
// default, and we add 2 mins for wallet confirmation
// default, and 2 mins are added for wallet confirmation
expect(screen.getByTestId('voting-date')).toHaveTextContent(
'2022-01-01T01:02:00.000Z'
);

2
libs/proposals/src/utils/get-closing-timestamp.ts
View File

@ -1,7 +1,7 @@
import { addHours, getTime } from 'date-fns';
import { addTwoMinutes, subtractTwoSeconds } from './deadline-helpers';
// If the vote deadline is at its minimum, then we add 2 extra minutes to the
// If the vote deadline is at its minimum, then 2 extra minutes are added to the
// closing timestamp to ensure that there's time to confirm in the wallet.
// If it's at its maximum, remove a couple of seconds to ensure rounding errors

2
libs/proposals/src/utils/get-enactment-timestamp.ts
View File

@ -1,7 +1,7 @@
import { addHours, getTime } from 'date-fns';
import { addTwoMinutes, subtractTwoSeconds } from './deadline-helpers';
// If the enactment deadline is at its minimum, then we add 2 extra minutes to the
// If the enactment deadline is at its minimum, then 2 extra minutes are added to the
// closing timestamp to ensure that there's time to confirm in the wallet.
// If it's at its maximum, remove a couple of seconds to ensure rounding errors

3
libs/web3/src/lib/withdrawal-approval-dialog.tsx
View File

@ -50,8 +50,7 @@ export const WithdrawalApprovalDialog = ({
<p>
{t(
`If the network is reset or has an outage, records of your withdrawal
may be lost. We recommend you save these details in a safe place so
you can still complete your withdrawal.`
may be lost. It is recommended that you save these details in a safe place so you can still complete your withdrawal.`
)}
</p>
{withdrawalId ? (