## Description + fixing `x/bank/migrations/v44.migrateDenomMetadata` - we could potentially put a wrong data in a new key if the old keys have variable length. + linting the code Putting in the same PR because i found the issue when running a linter. Depends on: #10112 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
5.2 KiB
Updating the docs
If you want to open a PR in Cosmos SDK to update the documentation, please follow the guidelines in CONTRIBUTING.md.
Internationalization
- Translations for documentation live in a
docs/<locale>/folder, where<locale>is the language code for a specific language. For example,zhfor Chinese,kofor Korean,rufor Russian, etc. - Each
docs/<locale>/folder must follow the same folder structure withindocs/, but only content in the following folders needs to be translated and included in the respectivedocs/<locale>/folder:docs/basics/docs/building-modules/docs/core/docs/ibc/docs/intro/docs/migrations/docs/run-node/
- Each
docs/<locale>/folder must also have aREADME.mdthat includes a translated version of both the layout and content within the root-levelREADME.md. The layout defined in theREADME.mdis used to build the homepage. - Always translate content living on
masterunless you are revising documentation for a specific release. Translated documentation like the root-level documentation is semantically versioned. - For additional configuration options, please see VuePress Internationalization.
Docs Build Workflow
The documentation for Cosmos SDK is hosted at https://docs.cosmos.network/ and built from the files in the /docs directory.
How It Works
There is a CircleCI job listening for changes in the /docs directory for the master branch and each supported version tag (v0.39 and v0.42). Any updates to files in the /docs directory will automatically trigger a website deployment. Under the hood, the private website repository has a make build-docs target consumed by a CircleCI job within that repository.
README
The README.md is both the README for the repository and the configuration for the layout of the landing page.
Config.js
The config.js generates the sidebar and Table of Contents on the website docs. Note the use of relative links and the omission of file extensions. Additional features are available to improve the look of the sidebar.
Links
NOTE: Strongly consider the existing links - both within this directory and to the website docs - when moving or deleting files.
Relative links should be used nearly everywhere, having discovered and weighed the following:
Relative
Where is the other file, relative to the current one?
- works both on GitHub and for the VuePress build
- confusing / annoying to have things like:
../../../../myfile.md - requires more updates when files are re-shuffled
Absolute
Where is the other file, given the root of the repo?
- works on GitHub, doesn't work for the VuePress build
- this is much nicer:
/docs/hereitis/myfile.md - if you move that file around, the links inside it are preserved (but not to it, of course)
Full
The full GitHub URL to a file or directory. Used occasionally when it makes sense to send users to the GitHub.
Building Locally
Make sure you are in the docs directory and run the following commands:
rm -rf node_modules
This command will remove old version of the visual theme and required packages. This step is optional.
npm install
Install the theme and all dependencies.
npm run serve
Run pre and post hooks and start a hot-reloading web-server. See output of this command for the URL (it is often https://localhost:8080).
To build documentation as a static website run npm run build. You will find the website in .vuepress/dist directory.
Build RPC Docs
First, run make tools from the root of repo, to install the swagger-ui tool.
Then, edit the swagger.yaml manually; it is found here
Finally, run make update_gaia_lite_docs from the root of the repo.
Search
We are using Algolia to power full-text search. This uses a public API search-only key in the config.js as well as a cosmos_network.json configuration file that we can update with PRs.
Consistency
Because the build processes are identical (as is the information contained herein), this file should be kept in sync as much as possible with its counterpart in the Tendermint Core repo.
Update and Build the RPC docs
-
Execute the following command at the root directory to install the swagger-ui generate tool.
make tools -
Edit API docs
- Directly Edit API docs manually:
client/lcd/swagger-ui/swagger.yaml. - Edit API docs within the Swagger Editor. Please refer to this document for the correct structure in
.yaml.
- Directly Edit API docs manually:
-
Download
swagger.yamland replace the oldswagger.yamlunder foldclient/lcd/swagger-ui. -
Compile gaiacli
make install