cosmos-sdk/x/feegrant/client
atheeshp b1725bf151
fix: (x/feegrant) expiration when overwriting an existing grant (#11845)
## Description
This PR couple of bugs with expiration not being updated when we overwrite an existing grant with different expiry.

**Bug 1**
`grantee`, `granter` passed wrongly to the `getGrant` method here:
a187a1c321/x/feegrant/keeper/keeper.go (L55)

`grantee` is passed at `granter`'s place and vice versa
a187a1c321/x/feegrant/keeper/keeper.go (L181-L196)

**Bug 2**
The following `if` condition never gets satisfied, `getGrant` returns `err`, `grant` with two possible out comes which are `nil`, `grant` or `err`, `nil` 
a187a1c321/x/feegrant/keeper/keeper.go (L56)

and also there is not only one possible error from `getGrant` with `fee-grant not found` and also one another possible error is unmarshal error, when there is an unmarshal error we should return the error.



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-05-06 05:48:45 +00:00
..
cli feat: add feegrant query to see allowances from a given granter (#10947) 2022-01-21 15:55:17 +01:00
testutil fix: (x/feegrant) expiration when overwriting an existing grant (#11845) 2022-05-06 05:48:45 +00:00