cosmos-sdk/x/feegrant
atheeshp b1725bf151
fix: (x/feegrant) expiration when overwriting an existing grant (#11845)
## Description
This PR couple of bugs with expiration not being updated when we overwrite an existing grant with different expiry.

**Bug 1**
`grantee`, `granter` passed wrongly to the `getGrant` method here:
a187a1c321/x/feegrant/keeper/keeper.go (L55)

`grantee` is passed at `granter`'s place and vice versa
a187a1c321/x/feegrant/keeper/keeper.go (L181-L196)

**Bug 2**
The following `if` condition never gets satisfied, `getGrant` returns `err`, `grant` with two possible out comes which are `nil`, `grant` or `err`, `nil` 
a187a1c321/x/feegrant/keeper/keeper.go (L56)

and also there is not only one possible error from `getGrant` with `fee-grant not found` and also one another possible error is unmarshal error, when there is an unmarshal error we should return the error.



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-05-06 05:48:45 +00:00
..
client fix: (x/feegrant) expiration when overwriting an existing grant (#11845) 2022-05-06 05:48:45 +00:00
keeper fix: (x/feegrant) expiration when overwriting an existing grant (#11845) 2022-05-06 05:48:45 +00:00
migrations/v046 feat: adds pruning for feegrant (#10830) 2022-02-08 03:40:56 +00:00
module fix: remove all RegisterRESTRoutes (#11797) 2022-04-27 12:23:34 -04:00
simulation fix: change SimulationState.InitialStake to sdkmath.Int (#11855) 2022-05-03 00:57:44 +02:00
spec docs: update feegrant AllowedFeeAllowance docs (#11344) 2022-03-11 14:44:44 +00:00
basic_fee_test.go refactor(test)!: refactor simapp.Setup function (#9938) 2021-08-17 00:52:06 +00:00
basic_fee.go refactor!: Coins Add and Sub Consistency (#11689) 2022-04-20 08:36:10 -04:00
codec.go revert: replace all ModuleCdc instances with legacy.Cdc (#11680) 2022-04-20 09:27:40 +00:00
doc.go Move x/feegrant/types to x/feegrant (#9273) 2021-05-07 07:10:47 +00:00
errors.go Move x/feegrant/types to x/feegrant (#9273) 2021-05-07 07:10:47 +00:00
events.go feat: adds pruning for feegrant (#10830) 2022-02-08 03:40:56 +00:00
expected_keepers.go Move x/feegrant/types to x/feegrant (#9273) 2021-05-07 07:10:47 +00:00
feegrant.pb.go docs: update feegrant AllowedFeeAllowance docs (#11344) 2022-03-11 14:44:44 +00:00
fees.go feat: adds pruning for feegrant (#10830) 2022-02-08 03:40:56 +00:00
filtered_fee_test.go chore: Bump gov and group to v1 (#11334) 2022-03-11 15:58:01 +00:00
filtered_fee.go feat: adds pruning for feegrant (#10830) 2022-02-08 03:40:56 +00:00
genesis.go Move x/feegrant/types to x/feegrant (#9273) 2021-05-07 07:10:47 +00:00
genesis.pb.go Move x/feegrant/types to x/feegrant (#9273) 2021-05-07 07:10:47 +00:00
grant_test.go refactor(test)!: refactor simapp.Setup function (#9938) 2021-08-17 00:52:06 +00:00
grant.go Move x/feegrant/types to x/feegrant (#9273) 2021-05-07 07:10:47 +00:00
key_test.go refactor: (x/feegrant) parsing keys (#11814) 2022-05-01 08:50:45 +00:00
key.go refactor: (x/feegrant) parsing keys (#11814) 2022-05-01 08:50:45 +00:00
msgs_test.go fix: implement Amino serialization for x/authz and x/feegrant (#11224) 2022-02-22 12:03:01 +01:00
msgs.go fix: implement Amino serialization for x/authz and x/feegrant (#11224) 2022-02-22 12:03:01 +01:00
periodic_fee_test.go refactor!: Coins Add and Sub Consistency (#11689) 2022-04-20 08:36:10 -04:00
periodic_fee.go refactor!: Coins Add and Sub Consistency (#11689) 2022-04-20 08:36:10 -04:00
query.pb.go feat: add feegrant query to see allowances from a given granter (#10947) 2022-01-21 15:55:17 +01:00
query.pb.gw.go fix: dockerfile for building proto (#11452) 2022-03-25 12:35:09 +00:00
README.md docs: Improve markdownlint configuration (#11104) 2022-02-10 12:07:01 +00:00
tx.pb.go docs: update feegrant AllowedFeeAllowance docs (#11344) 2022-03-11 14:44:44 +00:00

Fee Grant

  • Fee Grant - Grant fee allowances for executing transactions.