Commit Graph

2785 Commits

Author SHA1 Message Date
Dev Ojha
94a3ce4c83 docs: Explain the expected return type within the store (#1452) 2018-06-29 13:45:11 -04:00
Dev Ojha
24a68d3bdf Merge PR #1451: crypto/keys: move checksum size into constants
Closes #1410
2018-06-29 09:52:32 +02:00
Dev Ojha
b66a5cc853 Merge PR #1455: tools: Add make format
This adds a command to automatically fix gofmt and misspell errors.
2018-06-29 09:37:16 +02:00
Dev Ojha
337e87b228 Merge PR #1449: crypto/keys: make bcrypt security param a var
This is done so that the time spent on bcrypt during test cases
can be reduced. This change reduces the amount of time lcd tests
spend on bcrypt from 76% to 40%. (We need to reduce the number of
calls to bcrypt in a seperate PR, along with fixing other sources
of slowness)

Making the bcrypt security parameter a var shouldn't be a security issue:
One can't verify an invalid key by maliciously changing the bcrypt
parameter during a runtime vulnerability. The main security
threat this then exposes would be something that changes this during
runtime before the user creates their key. This vulnerability must
succeed to update this to that same value before every subsequent call
to gaiacli keys in future startups / or the attacker must get access
to the filesystem. However, with this same threat model (changing
variables in runtime), one can cause the user to sign a different tx
than what they see, which is a significantly cheaper attack then breaking
a bcrypt hash. (Recall that the nonce still exists to break rainbow
tables)
2018-06-29 09:22:06 +02:00
Dev Ojha
b4e70e356e Merge PR #1453: Fix build error on develop 2018-06-29 09:06:49 +02:00
Ethan Buchman
a88b6b9c97
Merge pull request #1376 from cosmos/bucky/docs-core
docs via example apps
2018-06-29 02:07:06 -04:00
Ethan Buchman
a7cdea5931 minor fix 2018-06-29 02:03:59 -04:00
Ethan Buchman
4e87cdf444 add links for modules and clients 2018-06-29 01:59:52 -04:00
Ethan Buchman
822ebdb501 cleanup _attic 2018-06-29 01:53:43 -04:00
Ethan Buchman
12a180786a started app5 2018-06-29 01:31:06 -04:00
Ethan Buchman
f405bdf761 template app4.md. simplify app4.go 2018-06-29 00:41:44 -04:00
Ethan Buchman
1d4d9e922f simplify and complete app3 2018-06-28 23:42:04 -04:00
Yanqing Yang
c333050b59 Repair link of QuickStart->Documentation which was broken by #1289 (#1444) 2018-06-29 03:14:06 +02:00
Christopher Goes
59aadf42aa
Ledger integration (#931)
Merges the keybase and Ledger code from go-crypto (which is no more) into the SDK
Adds support for Ledger into gaiacli
Cherry-picks updated error handling from #1158
2018-06-29 02:54:47 +02:00
Ethan Buchman
d1a42e0691 satisfy linter 2018-06-28 20:23:09 -04:00
Ethan Buchman
d0efeb1020 fill in app3 todos. simplify app3.go 2018-06-28 20:17:50 -04:00
Ethan Buchman
778b102a52 more app1/app2 cleanup 2018-06-28 20:08:38 -04:00
Ethan Buchman
e7081040d0 address TODOs in app 1 and 2 2018-06-28 19:41:40 -04:00
Ethan Buchman
e8946e9b36 fixes from review 2018-06-28 19:06:37 -04:00
Dev Ojha
ac3adff1e8 Merge PR #1438: Tools: Add errcheck linter
This linter ensures that all errors are checked.
This is disabled in the client directories, since its not needed on
those writes
2018-06-29 00:52:10 +02:00
Ethan Buchman
7f59aa259f
Merge pull request #1371 from cosmos/bucky/gaiadebug-bech32
gaiadebug: support bech32
2018-06-28 16:09:50 -04:00
Ethan Buchman
3a96f8ffd1
Merge pull request #1434 from cosmos/bucky-aditya/docs-core
Bucky aditya/docs core
2018-06-28 15:35:15 -04:00
Rigel
b07a4654ff
Merge branch 'develop' into bucky/gaiadebug-bech32 2018-06-28 15:25:32 -04:00
David Kajpust
090aaf8137 Merge #1412: Add async flag and functionality to gaiacli send
* added async functionality to gaiacli
* addressed requested changes, updated changelog
2018-06-28 21:23:47 +02:00
Aditya Sripal
4e2eb240f3 Appease linter 2018-06-28 15:08:39 -04:00
Aditya Sripal
e3f38b6f6c Added some documentation 2018-06-28 15:08:34 -04:00
Aditya Sripal
98be0e7f76 Improved apps with better handling/routing and simpler MsgIssue 2018-06-28 15:08:30 -04:00
Christopher Goes
6037243250
Merge branch 'develop' into bucky/gaiadebug-bech32 2018-06-28 19:16:44 +02:00
Dev Ojha
3e14868bd6 Merge PR #1429: tools: Add ineffassign linter
* tools: Add ineffassign linter

This errors on assignments that don't actually do anything. i.e.

x, err := myFunc(1)
y, err = myFunc(2)

This will call out that the first function's call error was never
used.

* Fix makefile, add misspell to makefile
2018-06-28 19:12:02 +02:00
Dev Ojha
2755c66545 Merge PR #1424: tools: add unconvert linter
unconvert checks for unnecessary type conversions
2018-06-28 18:08:29 +02:00
Rigel
473ac4a38e Merge PR #1423: PR Template labels 2018-06-28 03:22:57 +02:00
Rigel
2f3e1a3fde
Merge branch 'develop' into bucky/gaiadebug-bech32 2018-06-27 20:41:42 -04:00
Dev Ojha
6d9f07dfee tools: Add go vet as a linter (#1421)
* tools: add go vet

* tools: Add go vet as a linter
2018-06-27 20:32:06 -04:00
Rigel
36e8c27786
Merge branch 'develop' into bucky/gaiadebug-bech32 2018-06-27 20:28:48 -04:00
Sunny Aggarwal
4effa6f8d4 Merge PR #1357: RESTful governance endpoints
* get deposit rest endpoint
* query proposals
* changelog
* fixed commented out headers
* fixed undeterministic tests
* increase circle test timeout
* MustBech32ifyAcc
* asdf
2018-06-28 01:49:59 +02:00
Rigel
9dbdb1a55f
Merge branch 'develop' into bucky/gaiadebug-bech32 2018-06-27 19:32:24 -04:00
Aditya
9b4838d96e Merge PR #1367: Set ChainID on InitChain
* Added chain-id to context in InitChain
* Fix bug in test
* fmt
* Appease linter
* updated changelog
* Remove chainID hack
* setCheckState in InitChain
* Fix bug
* Fix initialization errors in example tests
* Initialize app tests with default stake genesis
* fix comments
2018-06-28 00:45:10 +02:00
Dev Ojha
49f421db19 Merge PR #1332: benchmarks: Add benchmark for block time to bank module
* benchmarks: Add benchmark folder, and single benchmark for block time
* Move benchmark into module
* Fix merge conflict errors
* Fix spelling
* Add instructions to run benchmark
* Update auth_app_test.go
2018-06-28 00:33:56 +02:00
Dev Ojha
3dc2387124 Merge PR #1404: Add more context for errors when no address is provided 2018-06-27 19:39:57 +02:00
Joon
6018e719d2 Merge PR #1069: Oracle Module
fix prefixstore iterator
in progress
fix mock validator
fix NewContext
add to changelog
apply requests
fix mock
2018-06-27 19:21:12 +02:00
Ethan Buchman
6bbe295d7f app3 coin keeper 2018-06-27 12:45:01 -04:00
Ethan Buchman
0c5e3fdc74 some cleanup, remove old files 2018-06-27 10:08:55 -04:00
Ethan Buchman
b335d3bb70 app3 ante handler 2018-06-27 09:53:00 -04:00
Ethan Buchman
bd581b22e8 working on app3 2018-06-27 09:02:11 -04:00
Ethan Buchman
d6a01ba3a4 minor updates in App2 2018-06-27 08:24:40 -04:00
Ethan Buchman
0987787896 more app1 cleanup 2018-06-27 08:11:11 -04:00
Ethan Buchman
6a5a8b4721 minor cleanup 2018-06-27 07:59:20 -04:00
Ethan Buchman
fc81c14a16 update/finish app1 go and md 2018-06-27 07:51:46 -04:00
Ethan Buchman
354f9760f8 move AnteHandler to app2 and some cleanup in app3 2018-06-27 07:15:30 -04:00
Aditya Sripal
41c61d2cc7 Revert changes to app1 router 2018-06-27 07:15:30 -04:00