LaconicNetwork/cosmos-sdk
9
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

fix(x/evidence): return error in keeper (#16245)

Browse Source 
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
This commit is contained in:
Facundo Medica 2023-05-23 04:30:46 -03:00 committed by GitHub
parent 2843261161
commit df834c58d1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/integration/evidence/keeper/infraction_test.go
View File

@ -231,7 +231,8 @@ func TestHandleDoubleSign(t *testing.T) {
tstaking.Undelegate(sdk.AccAddress(operatorAddr), operatorAddr, totalBond, true)
// query evidence from store
evidences := f.evidenceKeeper.GetAllEvidence(ctx)
evidences, err := f.evidenceKeeper.GetAllEvidence(ctx)
assert.NilError(t, err)
assert.Assert(t, len(evidences) == 1)
}

5
x/evidence/genesis.go
View File

@ -34,7 +34,10 @@ func InitGenesis(ctx sdk.Context, k keeper.Keeper, gs *types.GenesisState) {
// ExportGenesis returns the evidence module's exported genesis.
func ExportGenesis(ctx sdk.Context, k keeper.Keeper) *types.GenesisState {
e := k.GetAllEvidence(ctx)
e, err := k.GetAllEvidence(ctx)
if err != nil {
panic(err)
}
evidence := make([]*codectypes.Any, len(e))
for i, evi := range e {
msg, ok := evi.(proto.Message)

4
x/evidence/genesis_test.go
View File

@ -93,7 +93,9 @@ func (suite *GenesisTestSuite) TestInitGenesis() {
},
false,
func() {
suite.Empty(suite.keeper.GetAllEvidence(suite.ctx))
ev, err := suite.keeper.GetAllEvidence(suite.ctx)
suite.Empty(ev)
suite.NoError(err)
},
},
}

6
x/evidence/keeper/keeper.go
View File

@ -165,13 +165,13 @@ func (k Keeper) IterateEvidence(ctx context.Context, cb func(exported.Evidence)
}
// GetAllEvidence returns all stored Evidence objects.
func (k Keeper) GetAllEvidence(ctx context.Context) (evidence []exported.Evidence) {
k.IterateEvidence(ctx, func(e exported.Evidence) error {
func (k Keeper) GetAllEvidence(ctx context.Context) (evidence []exported.Evidence, err error) {
err = k.IterateEvidence(ctx, func(e exported.Evidence) error {
evidence = append(evidence, e)
return nil
})
return evidence
return evidence, err
}
// MustUnmarshalEvidence attempts to decode and return an Evidence object from

3
x/evidence/keeper/keeper_test.go
View File

@ -214,8 +214,9 @@ func (suite *KeeperTestSuite) TestIterateEvidence() {
numEvidence := 100
suite.populateEvidence(ctx, numEvidence)
evidence := suite.evidenceKeeper.GetAllEvidence(ctx)
evidence, err := suite.evidenceKeeper.GetAllEvidence(ctx)
suite.Len(evidence, numEvidence)
suite.NoError(err)
}
func (suite *KeeperTestSuite) TestGetEvidenceHandler() {