LaconicNetwork/cosmos-sdk
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

fix(x/staking): use staking bonddenom in check (backport #22646) (#22649)

Browse Source 
Co-authored-by: Julien Robert <julien@rbrt.fr>
This commit is contained in:
mergify[bot] 2024-11-26 09:36:18 +01:00 committed by GitHub
parent 53dff03a36
commit d52f5e8642
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
x/staking/types/params.go
View File

@ -110,7 +110,7 @@ func (p Params) Validate() error {
return err
}
if err := validateKeyRotationFee(p.KeyRotationFee); err != nil {
if err := validateKeyRotationFee(p.BondDenom, p.KeyRotationFee); err != nil {
return err
}
@ -215,17 +215,13 @@ func validateMinCommissionRate(i interface{}) error {
return nil
}
func validateKeyRotationFee(i interface{}) error {
v, ok := i.(sdk.Coin)
if !ok {
return fmt.Errorf("invalid parameter type: %T", i)
func validateKeyRotationFee(bondDenom string, coin sdk.Coin) error {
if coin.IsNil() {
return fmt.Errorf("cons pubkey rotation fee cannot be nil: %s", coin)
}
if v.IsNil() {
return fmt.Errorf("cons pubkey rotation fee cannot be nil: %s", v)
}
if v.IsLTE(sdk.NewInt64Coin(sdk.DefaultBondDenom, 0)) {
return fmt.Errorf("cons pubkey rotation fee cannot be negative or zero: %s", v)
if coin.IsLTE(sdk.NewInt64Coin(bondDenom, 0)) {
return fmt.Errorf("cons pubkey rotation fee cannot be negative or zero: %s", coin)
}
return nil