refactor(x/accounts): add sender assertions to SendModuleMessageUntyped (#20197)

This commit is contained in:
son trinh 2024-04-27 00:46:06 +07:00 committed by GitHub
parent 84bae0737c
commit a6871c74c3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -324,6 +324,17 @@ func (k Keeper) sendAnyMessages(ctx context.Context, sender []byte, anyMessages
// SendModuleMessageUntyped can be used to send a message towards a module.
// It should be used when the response type is not known by the caller.
func (k Keeper) SendModuleMessageUntyped(ctx context.Context, sender []byte, msg implementation.ProtoMsg) (implementation.ProtoMsg, error) {
// do sender assertions.
wantSenders, _, err := k.codec.GetMsgV1Signers(msg)
if err != nil {
return nil, fmt.Errorf("cannot get signers: %w", err)
}
if len(wantSenders) != 1 {
return nil, fmt.Errorf("expected only one signer, got %d", len(wantSenders))
}
if !bytes.Equal(sender, wantSenders[0]) {
return nil, fmt.Errorf("%w: sender does not match expected sender", ErrUnauthorized)
}
resp, err := k.RouterService.MessageRouterService().InvokeUntyped(ctx, msg)
if err != nil {
return nil, err