LaconicNetwork/cosmos-sdk
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

chore(client/v2): explain breaking change v0.50 / v0.51 autocli (#17764)

Browse Source
This commit is contained in:
Julien Robert 2023-09-15 17:19:01 +02:00 committed by GitHub
parent a0bd4e9fb6
commit 9da9a23795
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
client/v2/CHANGELOG.md
View File

@ -34,4 +34,15 @@ Ref: https://keepachangelog.com/en/1.0.0/
# Changelog
## [Unreleased]
## [Unreleased]
<!-- ## [v2.1.0-alpha.1] to be tagged after v0.51 final-->
### API Breaking Changes
* [#17709](https://github.com/cosmos/cosmos-sdk/pull/17709) Address codecs have been removed from `autocli.AppOptions` and `flag.Builder`. Instead client/v2 uses the address codecs present in the context (introduced in [#17503](https://github.com/cosmos/cosmos-sdk/pull/17503)).
## [v2.0.0-alpha.1] <!-- to be tagged after tx support and v0.50 final-->
This is the first tagged version of client/v2.
It depends on the Cosmos SDK v0.50 release and fully supports AutoCLI.

2
client/v2/autocli/flag/address.go
View File

@ -80,7 +80,7 @@ func (a addressValue) Type() string {
type consensusAddressStringType struct{}
func (a consensusAddressStringType) NewValue(ctx context.Context, b *Builder) Value {
return &consensusAddressValue{addressValue: addressValue{addressCodec: b.ClientCtx.ConsensusAddressCodec, keyring: b.ClientCtx.Keyring}}
return &consensusAddressValue{addressValue: addressValue{addressCodec: b.ClientCtx.ConsensusAddressCodec, keyring: b.Keyring}}
}
func (a consensusAddressStringType) DefaultValue() string {