refactor(x/bank): Simplify the return (#21602)

This commit is contained in:
fx0x55 2024-09-09 18:08:10 +08:00 committed by GitHub
parent bf98b56cd6
commit 9672879d21
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -150,7 +150,7 @@ func (k BaseKeeper) DelegateCoins(ctx context.Context, delegatorAddr, moduleAccA
if err != nil {
return err
}
if err := k.EventService.EventManager(ctx).EmitKV(
if err = k.EventService.EventManager(ctx).EmitKV(
types.EventTypeCoinSpent,
event.NewAttribute(types.AttributeKeySpender, delAddrStr),
event.NewAttribute(sdk.AttributeKeyAmount, amt.String()),
@ -158,12 +158,7 @@ func (k BaseKeeper) DelegateCoins(ctx context.Context, delegatorAddr, moduleAccA
return err
}
err = k.addCoins(ctx, moduleAccAddr, amt)
if err != nil {
return err
}
return nil
return k.addCoins(ctx, moduleAccAddr, amt)
}
// UndelegateCoins performs undelegation by crediting amt coins to an account with
@ -181,8 +176,7 @@ func (k BaseKeeper) UndelegateCoins(ctx context.Context, moduleAccAddr, delegato
return errorsmod.Wrap(sdkerrors.ErrInvalidCoins, amt.String())
}
err := k.subUnlockedCoins(ctx, moduleAccAddr, amt)
if err != nil {
if err := k.subUnlockedCoins(ctx, moduleAccAddr, amt); err != nil {
return err
}
@ -190,12 +184,7 @@ func (k BaseKeeper) UndelegateCoins(ctx context.Context, moduleAccAddr, delegato
return errorsmod.Wrap(err, "failed to track undelegation")
}
err = k.addCoins(ctx, delegatorAddr, amt)
if err != nil {
return err
}
return nil
return k.addCoins(ctx, delegatorAddr, amt)
}
// GetSupply retrieves the Supply from store