LaconicNetwork/cosmos-sdk
10
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Merge PR #2413: Remove reflection from handlers

Browse Source
This commit is contained in:
Dev Ojha 2018-09-26 14:04:07 -07:00 committed by Christopher Goes
parent cb86efa054
commit 7d5bc459fa
5 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/sdk/sdk-by-examples/simple-governance/module-handler.md
View File

@ -17,7 +17,7 @@ func NewHandler(k Keeper) sdk.Handler {
case VoteMsg:
return handleVoteMsg(ctx, k, msg)
default:
errMsg := "Unrecognized gov Msg type: " + reflect.TypeOf(msg).Name()
errMsg := "Unrecognized gov Msg type: " + msg.Name()
return sdk.ErrUnknownRequest(errMsg).Result()
}
}

3
examples/democoin/x/cool/handler.go
View File

@ -2,7 +2,6 @@ package cool
import (
"fmt"
"reflect"
sdk "github.com/cosmos/cosmos-sdk/types"
)
@ -26,7 +25,7 @@ func NewHandler(k Keeper) sdk.Handler {
case MsgQuiz:
return handleMsgQuiz(ctx, k, msg)
default:
errMsg := fmt.Sprintf("Unrecognized cool Msg type: %v", reflect.TypeOf(msg).Name())
errMsg := fmt.Sprintf("Unrecognized cool Msg type: %v", msg.Name())
return sdk.ErrUnknownRequest(errMsg).Result()
}
}

4
examples/democoin/x/pow/handler.go
View File

@ -1,8 +1,6 @@
package pow
import (
"reflect"
sdk "github.com/cosmos/cosmos-sdk/types"
)
@ -12,7 +10,7 @@ func (pk Keeper) Handler(ctx sdk.Context, msg sdk.Msg) sdk.Result {
case MsgMine:
return handleMsgMine(ctx, pk, msg)
default:
errMsg := "Unrecognized pow Msg type: " + reflect.TypeOf(msg).Name()
errMsg := "Unrecognized pow Msg type: " + msg.Name()
return sdk.ErrUnknownRequest(errMsg).Result()
}
}

4
x/bank/handler.go
View File

@ -1,8 +1,6 @@
package bank
import (
"reflect"
sdk "github.com/cosmos/cosmos-sdk/types"
)
@ -15,7 +13,7 @@ func NewHandler(k Keeper) sdk.Handler {
case MsgIssue:
return handleMsgIssue(ctx, k, msg)
default:
errMsg := "Unrecognized bank Msg type: " + reflect.TypeOf(msg).Name()
errMsg := "Unrecognized bank Msg type: %s" + msg.Name()
return sdk.ErrUnknownRequest(errMsg).Result()
}
}

4
x/ibc/handler.go
View File

@ -1,8 +1,6 @@
package ibc
import (
"reflect"
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/cosmos/cosmos-sdk/x/bank"
)
@ -15,7 +13,7 @@ func NewHandler(ibcm Mapper, ck bank.Keeper) sdk.Handler {
case IBCReceiveMsg:
return handleIBCReceiveMsg(ctx, ibcm, ck, msg)
default:
errMsg := "Unrecognized IBC Msg type: " + reflect.TypeOf(msg).Name()
errMsg := "Unrecognized IBC Msg type: " + msg.Name()
return sdk.ErrUnknownRequest(errMsg).Result()
}
}