fix: correct typos and remove duplicate code across client and baseapp packages (#24991)

Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>
This commit is contained in:
bigbear
2025-07-25 18:10:21 +00:00
committed by GitHub
co-authored by Alex | Interchain Labs
parent db3f09e679
commit 64bd1a134e
7 changed files with 7 additions and 8 deletions
+2 -2
View File
@@ -242,10 +242,10 @@ func checkMultipleSigners(tx authsigning.Tx) error {
return nil
}
// Sign signs a given tx with a named key. The bytes signed over are canconical.
// Sign signs a given tx with a named key. The bytes signed over are canonical.
// The resulting signature will be added to the transaction builder overwriting the previous
// ones if overwrite=true (otherwise, the signature will be appended).
// Signing a transaction with mutltiple signers in the DIRECT mode is not supported and will
// Signing a transaction with multiple signers in the DIRECT mode is not supported and will
// return an error.
// An error is returned upon failure.
func Sign(ctx context.Context, txf Factory, name string, txBuilder client.TxBuilder, overwriteSig bool) error {
+1 -1
View File
@@ -315,7 +315,7 @@ func TestSign(t *testing.T) {
/**** test double sign Direct mode
signing transaction with 2 or more DIRECT signers should fail in DIRECT mode ****/
{
"direct: should append a DIRECT signature with existing AMINO",
"direct: should append a DIRECT signature with existing AMINO",
// txb already has 1 AMINO signature
txfDirect, txb, from1, false,
[]cryptotypes.PubKey{pubKey2, pubKey1},