fix: correct typos and remove duplicate code across client and baseapp packages (#24991)

Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>

baseapp/utils_test.go

@@ -432,7 +432,6 @@ func setFailOnHandler(cfg client.TxConfig, tx signing.Tx, fail bool) signing.Tx
 func wonkyMsg(t *testing.T, cfg client.TxConfig, tx signing.Tx) signing.Tx {
 	t.Helper()
 
-	t.Helper()
 	builder := cfg.NewTxBuilder()
 	builder.SetMemo(tx.GetMemo())
 

client/flags/flags.go

@@ -130,7 +130,7 @@ func AddTxFlagsToCmd(cmd *cobra.Command) {
 	f.String(FlagGasPrices, "", "Gas prices in decimal format to determine the transaction fee (e.g. 0.1uatom)")
 	f.String(FlagNode, "tcp://localhost:26657", "<host>:<port> to CometBFT rpc interface for this chain")
 	f.Bool(FlagUseLedger, false, "Use a connected Ledger device")
-	f.Float64(FlagGasAdjustment, DefaultGasAdjustment, "adjustment factor to be multiplied against the estimate returned by the tx simulation; if the gas limit is set manually this flag is ignored ")
+	f.Float64(FlagGasAdjustment, DefaultGasAdjustment, "adjustment factor to be multiplied against the estimate returned by the tx simulation; if the gas limit is set manually this flag is ignored")
 	f.StringP(FlagBroadcastMode, "b", BroadcastSync, "Transaction broadcasting mode (sync|async)")
 	f.Bool(FlagDryRun, false, "ignore the --gas flag and perform a simulation of a transaction, but don't broadcast it (when enabled, the local Keybase is not accessible)")
 	f.Bool(FlagGenerateOnly, false, "Build an unsigned transaction and write it to STDOUT (when enabled, the local Keybase only accessed when providing a key name)")

client/keys/mnemonic.go

@@ -17,7 +17,7 @@ const (
 	mnemonicEntropySize = 256
 )
 
-// MnemonicKeyCommand computes the bip39 memonic for input entropy.
+// MnemonicKeyCommand computes the bip39 mnemonic for input entropy.
 func MnemonicKeyCommand() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "mnemonic",

client/tx/tx.go

@@ -242,10 +242,10 @@ func checkMultipleSigners(tx authsigning.Tx) error {
 	return nil
 }
 
-// Sign signs a given tx with a named key. The bytes signed over are canconical.
+// Sign signs a given tx with a named key. The bytes signed over are canonical.
 // The resulting signature will be added to the transaction builder overwriting the previous
 // ones if overwrite=true (otherwise, the signature will be appended).
-// Signing a transaction with mutltiple signers in the DIRECT mode is not supported and will
+// Signing a transaction with multiple signers in the DIRECT mode is not supported and will
 // return an error.
 // An error is returned upon failure.
 func Sign(ctx context.Context, txf Factory, name string, txBuilder client.TxBuilder, overwriteSig bool) error {

client/tx/tx_test.go

@@ -315,7 +315,7 @@ func TestSign(t *testing.T) {
 		/**** test double sign Direct mode
 		  signing transaction with 2 or more DIRECT signers should fail in DIRECT mode ****/
 		{
-			"direct: should  append a DIRECT signature with existing AMINO",
+			"direct: should append a DIRECT signature with existing AMINO",
 			// txb already has 1 AMINO signature
 			txfDirect, txb, from1, false,
 			[]cryptotypes.PubKey{pubKey2, pubKey1},

client/v2/autocli/flag/doc.go

@@ -1,4 +1,4 @@
 // Package flag defines functionality for automatically managing command
-// line flags as well positional arguments that are based on protobuf message
+// line flags as well as positional arguments that are based on protobuf message
 // fields.
 package flag

client/v2/autocli/query_test.go

@@ -575,7 +575,7 @@ func TestBinaryFlag(t *testing.T) {
 }
 
 func TestAddressValidation(t *testing.T) {
-	t.Skip() // TODO(@julienrbrt) re-able with better keyring instiantiation
+	t.Skip() // TODO(@julienrbrt) re-able with better keyring instantiation
 
 	fixture := initFixture(t)