LaconicNetwork/cosmos-sdk
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

refactor(store): add miss defer (#20602)

Browse Source
This commit is contained in:
Hoa Nguyen 2024-06-11 16:02:36 +07:00 committed by GitHub
parent 28fa3b8dfc
commit 4fa658e687
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
store/v2/commitment/store.go
View File

@ -134,6 +134,7 @@ func (c *CommitStore) LoadVersion(targetVersion uint64) error {
}
if targetVersion < latestVersion {
batch := c.db.NewBatch()
defer batch.Close()
for version := latestVersion; version > targetVersion; version-- {
cInfoKey := []byte(fmt.Sprintf(commitInfoKeyFmt, version))
if err := batch.Delete(cInfoKey); err != nil {
@ -186,6 +187,7 @@ func (c *CommitStore) flushCommitInfo(version uint64, cInfo *proof.CommitInfo) e
}
batch := c.db.NewBatch()
defer batch.Close()
cInfoKey := []byte(fmt.Sprintf(commitInfoKeyFmt, version))
value, err := cInfo.Marshal()
if err != nil {
@ -306,6 +308,7 @@ func (c *CommitStore) Get(storeKey []byte, version uint64, key []byte) ([]byte,
func (c *CommitStore) Prune(version uint64) (ferr error) {
// prune the metadata
batch := c.db.NewBatch()
defer batch.Close()
for v := version; v > 0; v-- {
cInfoKey := []byte(fmt.Sprintf(commitInfoKeyFmt, v))
if exist, _ := c.db.Has(cInfoKey); !exist {

1
store/v2/migration/manager.go
View File

@ -197,7 +197,6 @@ func (m *Manager) writeChangeset() error {
if err != nil {
return err
}
batch.Close()
}
return nil