LaconicNetwork/cosmos-sdk
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

ibc: UpdateChain fix blockid

Browse Source
This commit is contained in:
Ethan Buchman 2017-06-22 20:32:22 -04:00
parent f5e96a8d31
commit 19999ea517
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
plugins/ibc/ibc.go
View File

@ -570,7 +570,17 @@ func verifyCommit(chainState BlockchainState, header *tm.Header, commit *tm.Comm
chainID := chainState.ChainID
vals := chainState.Validators
valSet := tm.NewValidatorSet(vals)
blockID := commit.Precommits[0].BlockID // XXX: incorrect
var blockID tm.BlockID
for _, pc := range commit.Precommits {
// XXX: incorrect. we want the one for +2/3, not just the first one
if pc != nil {
blockID = pc.BlockID
}
}
if blockID.IsZero() {
return errors.New("All precommits are nil!")
}
// NOTE: Currently this only works with the exact same validator set.
// Not this, but perhaps "ValidatorSet.VerifyCommitAny" should expose