LaconicNetwork/cosmos-sdk
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

test(upgrade): Add Test Case for Missing Upgrade Handler (#24954)

Browse Source 
Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>
This commit is contained in:
Leon cap
2025-07-28 18:10:28 +00:00
committed by GitHub
co-authored by Alex | Interchain Labs
parent 4c6bdd257a
commit 15de68f27a
1 changed files with 48 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
x/upgrade/abci_test.go
+48 -1
View File
@@ -386,7 +386,6 @@ func TestDumpUpgradeInfoToFile(t *testing.T) {
require.Nil(t, err)
}
// TODO: add testcase to for `no upgrade handler is present for last applied upgrade`.
func TestBinaryVersion(t *testing.T) {
var skipHeight int64 = 15
s := setupTest(t, 10, map[int64]bool{skipHeight: true})
@@ -447,6 +446,54 @@ func TestBinaryVersion(t *testing.T) {
}
}
// TestMissingUpgradeHandler tests the scenario when no upgrade handler is present for last applied upgrade
func TestMissingUpgradeHandler(t *testing.T) {
// Setup test environment similar to TestDowngradeVerification
encCfg := moduletestutil.MakeTestEncodingConfig(upgrade.AppModuleBasic{})
key := storetypes.NewKVStoreKey(types.StoreKey)
storeService := runtime.NewKVStoreService(key)
testCtx := testutil.DefaultContextWithDB(t, key, storetypes.NewTransientStoreKey("transient_test"))
ctx := testCtx.Ctx.WithHeaderInfo(header.Info{Time: time.Now(), Height: 10})
// Use the same temp directory for both keepers to share storage
tempDir := t.TempDir()
skip := map[int64]bool{}
k := keeper.NewKeeper(skip, storeService, encCfg.Codec, tempDir, nil, authtypes.NewModuleAddress(govtypes.ModuleName).String())
m := upgrade.NewAppModule(k, addresscodec.NewBech32Codec("cosmos"))
// Submit and execute an upgrade plan with handler
planName := "test_upgrade"
err := k.ScheduleUpgrade(ctx, types.Plan{Name: planName, Height: ctx.HeaderInfo().Height + 1})
require.NoError(t, err)
ctx = ctx.WithHeaderInfo(header.Info{Height: ctx.HeaderInfo().Height + 1})
// Set the handler and execute upgrade
k.SetUpgradeHandler(planName, func(_ context.Context, _ types.Plan, vm module.VersionMap) (module.VersionMap, error) {
return vm, nil
})
// Successful upgrade
_, err = m.PreBlock(ctx)
require.NoError(t, err)
ctx = ctx.WithHeaderInfo(header.Info{Height: ctx.HeaderInfo().Height + 1})
// Now simulate a restart without the upgrade handler (missing handler scenario)
// Use the same temp directory and store service to maintain state
newKeeper := keeper.NewKeeper(skip, storeService, encCfg.Codec, tempDir, nil, authtypes.NewModuleAddress(govtypes.ModuleName).String())
newModule := upgrade.NewAppModule(newKeeper, addresscodec.NewBech32Codec("cosmos"))
// Verify that the last applied upgrade exists but no handler is present
lastAppliedPlan, _, err := newKeeper.GetLastCompletedUpgrade(ctx)
require.NoError(t, err)
require.Equal(t, planName, lastAppliedPlan)
require.False(t, newKeeper.HasHandler(planName))
// This should trigger an error because no handler exists for the last applied upgrade
_, err = newModule.PreBlock(ctx)
require.Error(t, err)
require.Contains(t, err.Error(), "upgrade handler is missing for test_upgrade upgrade plan")
}
func TestDowngradeVerification(t *testing.T) {
// could not use setupTest() here, because we have to use the same key
// for the two keepers.