From 5afe7a29aea75408f3843fd8ca01bddecb7c452c Mon Sep 17 00:00:00 2001
From: David Boreham <david@bozemanpass.com>
Date: Mon, 31 Jul 2023 15:08:34 -0600
Subject: [PATCH] Add a basic deployment test (#476)

---
 app/data/stacks/test/deploy/commands.py |  7 ++++
 app/deployment_create.py                |  2 +-
 tests/deploy/run-deploy-test.sh         | 44 +++++++++++++++++++++++--
 3 files changed, 49 insertions(+), 4 deletions(-)

diff --git a/app/data/stacks/test/deploy/commands.py b/app/data/stacks/test/deploy/commands.py
index 4947f976..d8fb557f 100644
--- a/app/data/stacks/test/deploy/commands.py
+++ b/app/data/stacks/test/deploy/commands.py
@@ -45,6 +45,13 @@ def init(command_context: DeployCommandContext):
     return yaml.load(default_spec_file_content)
 
 
+def create(command_context: DeployCommandContext):
+    data = "create-command-output-data"
+    output_file_path = command_context.deployment_dir.joinpath("create-file")
+    with open(output_file_path, 'w+') as output_file:
+        output_file.write(data)
+
+
 def get_state(command_context: DeployCommandContext):
     print("Here we get state")
     return State.CONFIGURED
diff --git a/app/deployment_create.py b/app/deployment_create.py
index bafb46cd..af5eefb2 100644
--- a/app/deployment_create.py
+++ b/app/deployment_create.py
@@ -209,7 +209,7 @@ def create(ctx, spec_file, deployment_dir):
     # stack member here.
     deployment_command_context = ctx.obj
     deployment_command_context.stack = stack_name
-    deployment_context = DeploymentContext(Path(deployment_dir), ctx.obj)
+    deployment_context = DeploymentContext(Path(deployment_dir), deployment_command_context)
     call_stack_deploy_create(deployment_context)
 
 
diff --git a/tests/deploy/run-deploy-test.sh b/tests/deploy/run-deploy-test.sh
index 70eb0e18..11b37b2f 100755
--- a/tests/deploy/run-deploy-test.sh
+++ b/tests/deploy/run-deploy-test.sh
@@ -26,17 +26,18 @@ $TEST_TARGET_SO --stack test build-containers
 # Test deploy command execution
 $TEST_TARGET_SO --stack test deploy setup $CERC_REPO_BASE_DIR
 # Check that we now have the expected output directory
-if [ ! -d "$CERC_REPO_BASE_DIR/container-output-dir" ]; then
+container_output_dir=$CERC_REPO_BASE_DIR/container-output-dir
+if [ ! -d "$container_output_dir" ]; then
     echo "deploy setup test: output directory not present"
     echo "deploy setup test: FAILED"
     exit 1
 fi
-if [ ! -f "$CERC_REPO_BASE_DIR/container-output-dir/output-file" ]; then
+if [ ! -f "$container_output_dir/output-file" ]; then
     echo "deploy setup test: output file not present"
     echo "deploy setup test: FAILED"
     exit 1
 fi
-output_file_content=$(<$CERC_REPO_BASE_DIR/container-output-dir/output-file)
+output_file_content=$(<$container_output_dir/output-file)
 if [ ! "$output_file_content" == "output-data"  ]; then
     echo "deploy setup test: output file contents not correct"
     echo "deploy setup test: FAILED"
@@ -73,4 +74,41 @@ else
     exit 1
 fi
 $TEST_TARGET_SO --stack test deploy down --delete-volumes
+# Basic test of creating a deployment
+test_deployment_dir=$CERC_REPO_BASE_DIR/test-deployment-dir
+test_deployment_spec=$CERC_REPO_BASE_DIR/test-deployment-spec.yml
+$TEST_TARGET_SO --stack test deploy init --output $test_deployment_spec
+# Check the file now exists
+if [ ! -f "$test_deployment_spec" ]; then
+    echo "deploy init test: spec file not present"
+    echo "deploy init test: FAILED"
+    exit 1
+fi
+echo "deploy init test: passed"
+$TEST_TARGET_SO deploy create --spec-file $test_deployment_spec --deployment-dir $test_deployment_dir
+# Check the deployment dir exists
+if [ ! -d "$test_deployment_dir" ]; then
+    echo "deploy create test: deployment directory not present"
+    echo "deploy create test: FAILED"
+    exit 1
+fi
+echo "deploy create test: passed"
+# Check the file writted by the create command in the stack now exists
+if [ ! -f "$test_deployment_dir/create-file" ]; then
+    echo "deploy create test: create output file not present"
+    echo "deploy create test: FAILED"
+    exit 1
+fi
+# And has the right content
+create_file_content=$(<$test_deployment_dir/create-file)
+if [ ! "$create_file_content" == "create-command-output-data"  ]; then
+    echo "deploy create test: create output file contents not correct"
+    echo "deploy create test: FAILED"
+    exit 1
+fi
+echo "deploy create output file test: passed"
+# Try to start the deployment
+$TEST_TARGET_SO deployment --dir $test_deployment_dir start
+# Stop and clean up
+$TEST_TARGET_SO deployment --dir $test_deployment_dir stop --delete-volumes
 echo "Test passed"