roysc/stack-orchestrator
1
0
Fork 0
Code Pull Requests Activity

Remove result code check

Browse Source 
Former-commit-id: 6faa933d42a6f80abecee635c8497d9d3502010d
This commit is contained in:
David Boreham 2023-01-19 13:30:01 -07:00
parent 8f9f23b1c4
commit 7d00228ca2
1 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/build_npms.py
View File

@ -85,7 +85,7 @@ def command(ctx, include, exclude):
print(f"Executing: {build_command}") print(f"Executing: {build_command}")
envs = {"CERC_NPM_AUTH_TOKEN": os.environ["CERC_NPM_AUTH_TOKEN"]} | ({"CERC_SCRIPT_DEBUG": "true"} if debug else {}) envs = {"CERC_NPM_AUTH_TOKEN": os.environ["CERC_NPM_AUTH_TOKEN"]} | ({"CERC_SCRIPT_DEBUG": "true"} if debug else {})
try: try:
build_result = docker.run("cerc/builder-js", docker.run("cerc/builder-js",
remove=True, remove=True,
interactive=True, interactive=True,
tty=True, tty=True,
@ -95,8 +95,9 @@ def command(ctx, include, exclude):
volumes=[(repo_full_path, "/workspace")], volumes=[(repo_full_path, "/workspace")],
command=build_command command=build_command
) )
# TODO: check result in build_result.returncode # Note that although the docs say that build_result should contain
print(f"Result is: {build_result}") # the command output as a string, in reality it is always the empty string.
# Since we detect errors via catching exceptions below, we can safely ignore it here.
except DockerException as e: except DockerException as e:
print(f"FATAL error executing build in container:\n {e}") print(f"FATAL error executing build in container:\n {e}")
else: else: