plugeth/p2p/discover
Felix Lange b4374436f3 p2p/discover: fix race involving the seed node iterator
nodeDB.querySeeds was not safe for concurrent use but could be called
concurrenty on multiple goroutines in the following case:

- the table was empty
- a timed refresh started
- a lookup was started and initiated refresh

These conditions are unlikely to coincide during normal use, but are
much more likely to occur all at once when the user's machine just woke
from sleep. The root cause of the issue is that querySeeds reused the
same leveldb iterator until it was exhausted.

This commit moves the refresh scheduling logic into its own goroutine
(so only one refresh is ever active) and changes querySeeds to not use
a persistent iterator. The seed node selection is now more random and
ignores nodes that have not been contacted in the last 5 days.
2015-09-30 16:23:03 +02:00
..
database_test.go p2p/discover: fix race involving the seed node iterator 2015-09-30 16:23:03 +02:00
database.go p2p/discover: fix race involving the seed node iterator 2015-09-30 16:23:03 +02:00
node_test.go all: fix license headers one more time 2015-07-23 18:35:11 +02:00
node.go p2p/discover: don't attempt to replace nodes that are being replaced 2015-08-19 14:57:16 +02:00
table_test.go p2p/discover: fix race involving the seed node iterator 2015-09-30 16:23:03 +02:00
table.go p2p/discover: fix race involving the seed node iterator 2015-09-30 16:23:03 +02:00
udp_test.go p2p/discover: fix UDP reply packet timeout handling 2015-08-11 11:42:17 +02:00
udp.go p2p/discover: fix race involving the seed node iterator 2015-09-30 16:23:03 +02:00