plugeth/common
Felix Lange 5f7826270c all: unify big.Int zero checks, use common/math in more places (#3716)
* common/math: optimize PaddedBigBytes, use it more

name              old time/op    new time/op    delta
PaddedBigBytes-8    71.1ns ± 5%    46.1ns ± 1%  -35.15%  (p=0.000 n=20+19)

name              old alloc/op   new alloc/op   delta
PaddedBigBytes-8     48.0B ± 0%     32.0B ± 0%  -33.33%  (p=0.000 n=20+20)

* all: unify big.Int zero checks

Various checks were in use. This commit replaces them all with Int.Sign,
which is cheaper and less code.

eg templates:

    func before(x *big.Int) bool { return x.BitLen() == 0 }
    func after(x *big.Int) bool  { return x.Sign() == 0 }

    func before(x *big.Int) bool { return x.BitLen() > 0 }
    func after(x *big.Int) bool  { return x.Sign() != 0 }

    func before(x *big.Int) int { return x.Cmp(common.Big0) }
    func after(x *big.Int) int  { return x.Sign() }

* common/math, crypto/secp256k1: make ReadBits public in package math
2017-02-28 15:09:11 +01:00
..
compiler cmd,eth,les,internal: remove natspec support 2017-01-17 12:13:50 +01:00
hexutil common/hexutil: fix EncodeBig, Big.MarshalJSON 2017-01-16 10:32:40 +01:00
math all: unify big.Int zero checks, use common/math in more places (#3716) 2017-02-28 15:09:11 +01:00
mclock les: light client protocol and API 2016-11-09 02:12:53 +01:00
number all: fix license headers one more time 2015-07-23 18:35:11 +02:00
big.go common: move big integer math to common/math (#3699) 2017-02-26 22:21:51 +01:00
bytes_test.go common: move big integer math to common/math (#3699) 2017-02-26 22:21:51 +01:00
bytes.go common: move big integer math to common/math (#3699) 2017-02-26 22:21:51 +01:00
debug.go core: added basic chain configuration 2016-04-01 01:01:10 +02:00
format.go all: fix issues reported by honnef.co/go/simple/cmd/gosimple 2017-01-06 18:18:07 +01:00
main_test.go all: fix license headers one more time 2015-07-23 18:35:11 +02:00
path.go common, node: move datadir defaults into package node 2016-09-16 15:24:31 +02:00
size_test.go common: move big integer math to common/math (#3699) 2017-02-26 22:21:51 +01:00
size.go common: move big integer math to common/math (#3699) 2017-02-26 22:21:51 +01:00
test_utils.go all: fix license headers one more time 2015-07-23 18:35:11 +02:00
types_template.go common: move big integer math to common/math (#3699) 2017-02-26 22:21:51 +01:00
types_test.go common: use package hexutil for fixed size type encoding 2016-11-28 11:37:13 +01:00
types.go common, eth/downloader, log: support terminal log formatting 2017-02-27 19:15:18 +02:00