forked from cerc-io/plugeth
4e474c74dc
Notifier tracks whether subscription are 'active'. A subscription becomes active when the subscription ID has been sent to the client. If the client sends notifications in the request handler before the subscription becomes active they are dropped. The tests tried to work around this problem by always waiting 5s before sending the first notification. Fix it by buffering notifications until the subscription becomes active. This speeds up all subscription tests. Also fix TestSubscriptionMultipleNamespaces to wait for three messages per subscription instead of six. The test now finishes just after all notifications have been received and doesn't hit the 30s timeout anymore.
150 lines
4.8 KiB
Go
150 lines
4.8 KiB
Go
// Copyright 2016 The go-ethereum Authors
|
|
// This file is part of the go-ethereum library.
|
|
//
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Lesser General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package rpc
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"sync"
|
|
)
|
|
|
|
var (
|
|
// ErrNotificationsUnsupported is returned when the connection doesn't support notifications
|
|
ErrNotificationsUnsupported = errors.New("notifications not supported")
|
|
// ErrNotificationNotFound is returned when the notification for the given id is not found
|
|
ErrSubscriptionNotFound = errors.New("subscription not found")
|
|
)
|
|
|
|
// ID defines a pseudo random number that is used to identify RPC subscriptions.
|
|
type ID string
|
|
|
|
// a Subscription is created by a notifier and tight to that notifier. The client can use
|
|
// this subscription to wait for an unsubscribe request for the client, see Err().
|
|
type Subscription struct {
|
|
ID ID
|
|
namespace string
|
|
err chan error // closed on unsubscribe
|
|
}
|
|
|
|
// Err returns a channel that is closed when the client send an unsubscribe request.
|
|
func (s *Subscription) Err() <-chan error {
|
|
return s.err
|
|
}
|
|
|
|
// notifierKey is used to store a notifier within the connection context.
|
|
type notifierKey struct{}
|
|
|
|
// Notifier is tight to a RPC connection that supports subscriptions.
|
|
// Server callbacks use the notifier to send notifications.
|
|
type Notifier struct {
|
|
codec ServerCodec
|
|
subMu sync.Mutex
|
|
active map[ID]*Subscription
|
|
inactive map[ID]*Subscription
|
|
buffer map[ID][]interface{} // unsent notifications of inactive subscriptions
|
|
}
|
|
|
|
// newNotifier creates a new notifier that can be used to send subscription
|
|
// notifications to the client.
|
|
func newNotifier(codec ServerCodec) *Notifier {
|
|
return &Notifier{
|
|
codec: codec,
|
|
active: make(map[ID]*Subscription),
|
|
inactive: make(map[ID]*Subscription),
|
|
buffer: make(map[ID][]interface{}),
|
|
}
|
|
}
|
|
|
|
// NotifierFromContext returns the Notifier value stored in ctx, if any.
|
|
func NotifierFromContext(ctx context.Context) (*Notifier, bool) {
|
|
n, ok := ctx.Value(notifierKey{}).(*Notifier)
|
|
return n, ok
|
|
}
|
|
|
|
// CreateSubscription returns a new subscription that is coupled to the
|
|
// RPC connection. By default subscriptions are inactive and notifications
|
|
// are dropped until the subscription is marked as active. This is done
|
|
// by the RPC server after the subscription ID is send to the client.
|
|
func (n *Notifier) CreateSubscription() *Subscription {
|
|
s := &Subscription{ID: NewID(), err: make(chan error)}
|
|
n.subMu.Lock()
|
|
n.inactive[s.ID] = s
|
|
n.subMu.Unlock()
|
|
return s
|
|
}
|
|
|
|
// Notify sends a notification to the client with the given data as payload.
|
|
// If an error occurs the RPC connection is closed and the error is returned.
|
|
func (n *Notifier) Notify(id ID, data interface{}) error {
|
|
n.subMu.Lock()
|
|
defer n.subMu.Unlock()
|
|
|
|
if sub, active := n.active[id]; active {
|
|
n.send(sub, data)
|
|
} else {
|
|
n.buffer[id] = append(n.buffer[id], data)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (n *Notifier) send(sub *Subscription, data interface{}) error {
|
|
notification := n.codec.CreateNotification(string(sub.ID), sub.namespace, data)
|
|
err := n.codec.Write(notification)
|
|
if err != nil {
|
|
n.codec.Close()
|
|
}
|
|
return err
|
|
}
|
|
|
|
// Closed returns a channel that is closed when the RPC connection is closed.
|
|
func (n *Notifier) Closed() <-chan interface{} {
|
|
return n.codec.Closed()
|
|
}
|
|
|
|
// unsubscribe a subscription.
|
|
// If the subscription could not be found ErrSubscriptionNotFound is returned.
|
|
func (n *Notifier) unsubscribe(id ID) error {
|
|
n.subMu.Lock()
|
|
defer n.subMu.Unlock()
|
|
if s, found := n.active[id]; found {
|
|
close(s.err)
|
|
delete(n.active, id)
|
|
return nil
|
|
}
|
|
return ErrSubscriptionNotFound
|
|
}
|
|
|
|
// activate enables a subscription. Until a subscription is enabled all
|
|
// notifications are dropped. This method is called by the RPC server after
|
|
// the subscription ID was sent to client. This prevents notifications being
|
|
// send to the client before the subscription ID is send to the client.
|
|
func (n *Notifier) activate(id ID, namespace string) {
|
|
n.subMu.Lock()
|
|
defer n.subMu.Unlock()
|
|
|
|
if sub, found := n.inactive[id]; found {
|
|
sub.namespace = namespace
|
|
n.active[id] = sub
|
|
delete(n.inactive, id)
|
|
// Send buffered notifications.
|
|
for _, data := range n.buffer[id] {
|
|
n.send(sub, data)
|
|
}
|
|
delete(n.buffer, id)
|
|
}
|
|
}
|