From fbe7caf13621e160cf8a1c6443016e4c012a9e53 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E8=B4=BA=E9=B9=8F=E9=A3=9E?= Date: Wed, 6 Mar 2019 22:31:41 +0800 Subject: [PATCH] core: cache tx signature before obtaining lock --- core/tx_pool.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/core/tx_pool.go b/core/tx_pool.go index 305dfcc22..411143aea 100644 --- a/core/tx_pool.go +++ b/core/tx_pool.go @@ -833,6 +833,9 @@ func (pool *TxPool) AddRemotes(txs []*types.Transaction) []error { // addTx enqueues a single transaction into the pool if it is valid. func (pool *TxPool) addTx(tx *types.Transaction, local bool) error { + // Cache sender in transaction before obtaining lock (pool.signer is immutable) + types.Sender(pool.signer, tx) + pool.mu.Lock() defer pool.mu.Unlock() @@ -851,6 +854,10 @@ func (pool *TxPool) addTx(tx *types.Transaction, local bool) error { // addTxs attempts to queue a batch of transactions if they are valid. func (pool *TxPool) addTxs(txs []*types.Transaction, local bool) []error { + // Cache senders in transactions before obtaining lock (pool.signer is immutable) + for _, tx := range txs { + types.Sender(pool.signer, tx) + } pool.mu.Lock() defer pool.mu.Unlock()