forked from cerc-io/plugeth
p2p/nat: delay auto discovery until first use
Port mapper auto discovery used to run immediately after parsing the --nat flag, giving it a slight performance boost. But this is becoming inconvenient because we create node.Node for all geth operations including account management and bare chain interaction. Delay autodiscovery until the first use instead, which avoids any network interaction until the node is actually started.
This commit is contained in:
parent
7c12e8ea44
commit
f5c432bcab
@ -197,11 +197,7 @@ type autodisc struct {
|
||||
|
||||
func startautodisc(what string, doit func() Interface) Interface {
|
||||
// TODO: monitor network configuration and rerun doit when it changes.
|
||||
ad := &autodisc{what: what, doit: doit}
|
||||
// Start the auto discovery as early as possible so it is already
|
||||
// in progress when the rest of the stack calls the methods.
|
||||
go ad.wait()
|
||||
return ad
|
||||
return &autodisc{what: what, doit: doit}
|
||||
}
|
||||
|
||||
func (n *autodisc) AddMapping(protocol string, extport, intport int, name string, lifetime time.Duration) error {
|
||||
|
Loading…
Reference in New Issue
Block a user