roysc/plugeth
1
0
Fork 0
forked from cerc-io/plugeth
Code Pull Requests Activity

p2p/nodestate: fix deadlock during shutdown of les server (#21927)

Browse Source 
This PR fixes a deadlock reported here: #21925

The cause is that many operations may be pending, but if the close happens, only one of them gets awoken and exits, the others remain waiting for a signal that never comes.
This commit is contained in:
Martin Holst Swende 2020-11-30 18:58:47 +01:00 committed by GitHub
parent a1ddd9e1d3
commit e7db1dbc96
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
p2p/nodestate/nodestate.go
View File

@ -725,7 +725,7 @@ func (ns *NodeStateMachine) opFinish() {
} }
ns.opPending = nil ns.opPending = nil
ns.opFlag = false ns.opFlag = false
ns.opWait.Signal() ns.opWait.Broadcast()
} }
// Operation calls the given function as an operation callback. This allows the caller // Operation calls the given function as an operation callback. This allows the caller