roysc/plugeth
1
0
Fork 0
forked from cerc-io/plugeth
Code Pull Requests Activity

node: require LocalAppData variable (#19132)

Browse Source 
* node: require LocalAppData variable

This avoids path inconsistencies on Windows XP.
Hat tip to @MicahZoltu for catching this so quickly.

* node: fix typo
This commit is contained in:
Felix Lange 2019-02-28 12:11:52 +01:00 committed by Péter Szilágyi
parent 62d9d63858
commit dd28ba378a
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
node/defaults.go
View File

@ -80,13 +80,14 @@ func DefaultDataDir() string {
} }
func windowsAppData() string { func windowsAppData() string {
if v := os.Getenv("LOCALAPPDATA"); v != "" { v := os.Getenv("LOCALAPPDATA")
return v // Vista+ if v == "" {
// Windows XP and below don't have LocalAppData. Crash here because
// we don't support Windows XP and undefining the variable will cause
// other issues.
panic("environment variable LocalAppData is undefined")
} }
if v := os.Getenv("APPDATA"); v != "" { return v
return filepath.Join(v, "Local")
}
return ""
} }
func isNonEmptyDir(dir string) bool { func isNonEmptyDir(dir string) bool {