roysc/plugeth
1
0
Fork 0
forked from cerc-io/plugeth
Code Pull Requests Activity

crypto: fix ineffectual assignments (#22124)

Browse Source 
* crypto/bls12381: fixed ineffectual assignment

* crypto/signify: fix ineffectual assignment
This commit is contained in:
Marius van der Wijden 2021-01-06 12:06:44 +01:00 committed by GitHub
parent 618454214b
commit d667ee2d10
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crypto/bls12381/arithmetic_fallback.go
View File

@ -207,7 +207,7 @@ func lsubAssign(z, x *fe) {
z[2], b = bits.Sub64(z[2], x[2], b) z[2], b = bits.Sub64(z[2], x[2], b)
z[3], b = bits.Sub64(z[3], x[3], b) z[3], b = bits.Sub64(z[3], x[3], b)
z[4], b = bits.Sub64(z[4], x[4], b) z[4], b = bits.Sub64(z[4], x[4], b)
z[5], b = bits.Sub64(z[5], x[5], b) z[5], _ = bits.Sub64(z[5], x[5], b)
} }
func neg(z *fe, x *fe) { func neg(z *fe, x *fe) {

4
crypto/signify/signify_fuzz.go
View File

@ -25,7 +25,6 @@ import (
"log" "log"
"os" "os"
"os/exec" "os/exec"
"runtime"
fuzz "github.com/google/gofuzz" fuzz "github.com/google/gofuzz"
"github.com/jedisct1/go-minisign" "github.com/jedisct1/go-minisign"
@ -129,6 +128,9 @@ func getKey(fileS string) (string, error) {
func createKeyPair() (string, string) { func createKeyPair() (string, string) {
// Create key and put it in correct format // Create key and put it in correct format
tmpKey, err := ioutil.TempFile("", "") tmpKey, err := ioutil.TempFile("", "")
if err != nil {
panic(err)
}
defer os.Remove(tmpKey.Name()) defer os.Remove(tmpKey.Name())
defer os.Remove(tmpKey.Name() + ".pub") defer os.Remove(tmpKey.Name() + ".pub")
defer os.Remove(tmpKey.Name() + ".sec") defer os.Remove(tmpKey.Name() + ".sec")