roysc/plugeth
1
0
Fork 0
forked from cerc-io/plugeth
Code Pull Requests Activity

watches are calling callback with a single result object, not a full jsonrpc response

Browse Source
This commit is contained in:
Marek Kotewicz 2015-01-26 16:22:40 +01:00
parent 81bbe8c93b
commit d0b6f3663b
5 changed files with 18 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
dist/ethereum.js vendored
View File

@ -573,8 +573,10 @@ Filter.prototype.changed = function(callback) {
/// trigger calling new message from people /// trigger calling new message from people
Filter.prototype.trigger = function(messages) { Filter.prototype.trigger = function(messages) {
for(var i = 0; i < this.callbacks.length; i++) { for (var i = 0; i < this.callbacks.length; i++) {
this.callbacks[i].call(this, messages); for (var j = 0; j < messages; j++) {
this.callbacks[i].call(this, messages[j]);
}
} }
}; };
@ -716,12 +718,12 @@ var ProviderManager = function() {
result = JSON.parse(result); result = JSON.parse(result);
// dont call the callback if result is an error, empty array or false // dont call the callback if result is not an array, or empty one
if (result.error || (result.result instanceof Array ? result.result.length === 0 : !result.result)) { if (result.error || !(result.result instanceof Array) || result.result.length === 0) {
return; return;
} }
data.callback(result); data.callback(result.result);
}); });
} }
setTimeout(poll, 12000); setTimeout(poll, 12000);

6
dist/ethereum.js.map vendored
View File

File diff suppressed because one or more lines are too long

2
dist/ethereum.min.js vendored
View File

File diff suppressed because one or more lines are too long

6
lib/filter.js
View File

@ -47,8 +47,10 @@ Filter.prototype.changed = function(callback) {
/// trigger calling new message from people /// trigger calling new message from people
Filter.prototype.trigger = function(messages) { Filter.prototype.trigger = function(messages) {
for(var i = 0; i < this.callbacks.length; i++) { for (var i = 0; i < this.callbacks.length; i++) {
this.callbacks[i].call(this, messages); for (var j = 0; j < messages; j++) {
this.callbacks[i].call(this, messages[j]);
}
} }
}; };

6
lib/providermanager.js
View File

@ -49,12 +49,12 @@ var ProviderManager = function() {
result = JSON.parse(result); result = JSON.parse(result);
// dont call the callback if result is an error, empty array or false // dont call the callback if result is not an array, or empty one
if (result.error || (result.result instanceof Array ? result.result.length === 0 : !result.result)) { if (result.error || !(result.result instanceof Array) || result.result.length === 0) {
return; return;
} }
data.callback(result); data.callback(result.result);
}); });
} }
setTimeout(poll, 12000); setTimeout(poll, 12000);