all: more linters (#24783)

This enables the following linters

- typecheck
- unused
- staticcheck
- bidichk
- durationcheck
- exportloopref
- gosec

WIth a few exceptions.

- We use a deprecated protobuf in trezor. I didn't want to mess with that, since I cannot meaningfully test any changes there.
- The deprecated TypeMux is used in a few places still, so the warning for it is silenced for now.
- Using string type in context.WithValue is apparently wrong, one should use a custom type, to prevent collisions between different places in the hierarchy of callers. That should be fixed at some point, but may require some attention.
- The warnings for using weak random generator are squashed, since we use a lot of random without need for cryptographic guarantees.

This commit is contained in:

Martin Holst Swende

2022-06-13 16:24:45 +02:00

committed by

GitHub

parent eb94896270

commit a907d7e81a

67 changed files with 156 additions and 423 deletions

									
										crypto/bn256/cloudflare/gfp_decl.go
									
		+1
		-1
	
												View File
												
				@@ -10,7 +10,7 @@ import (

					"golang.org/x/sys/cpu"

				)

				//nolint:varcheck

				//nolint:varcheck,unused,deadcode

				var hasBMI2 = cpu.X86.HasBMI2

				// go:noescape