From 9d152d6191349316d610208af2f55ef578785355 Mon Sep 17 00:00:00 2001 From: Felix Lange Date: Wed, 22 Apr 2015 10:58:11 +0200 Subject: [PATCH] common: delete BinaryLength The test is failing the 32bit build and the function is not used anywhere. --- common/bytes.go | 11 ----------- common/bytes_test.go | 14 -------------- 2 files changed, 25 deletions(-) diff --git a/common/bytes.go b/common/bytes.go index 5d1245107..d279156b4 100644 --- a/common/bytes.go +++ b/common/bytes.go @@ -106,17 +106,6 @@ func ReadVarInt(buff []byte) (ret uint64) { return } -// Binary length -// -// Returns the true binary length of the given number -func BinaryLength(num int) int { - if num == 0 { - return 0 - } - - return 1 + BinaryLength(num>>8) -} - // Copy bytes // // Returns an exact copy of the provided bytes diff --git a/common/bytes_test.go b/common/bytes_test.go index 4b00aa49b..069af984c 100644 --- a/common/bytes_test.go +++ b/common/bytes_test.go @@ -79,20 +79,6 @@ func (s *BytesSuite) TestReadVarInt(c *checker.C) { c.Assert(res1, checker.Equals, exp1) } -func (s *BytesSuite) TestBinaryLength(c *checker.C) { - data1 := 0 - data2 := 920987656789 - - exp1 := 0 - exp2 := 5 - - res1 := BinaryLength(data1) - res2 := BinaryLength(data2) - - c.Assert(res1, checker.Equals, exp1) - c.Assert(res2, checker.Equals, exp2) -} - func (s *BytesSuite) TestCopyBytes(c *checker.C) { data1 := []byte{1, 2, 3, 4} exp1 := []byte{1, 2, 3, 4}