roysc/plugeth
1
0
Fork 0
forked from cerc-io/plugeth
Code Pull Requests Activity

rpc: dont log an error if user configures --rpcapi=rpc... (#20776)

Browse Source 
This just prevents a false negative ERROR warning when, for some unknown
reason, a user attempts to turn on the module rpc even though it's already going
to be on.
This commit is contained in:
meowsbits 2020-03-21 09:28:27 -05:00 committed by GitHub
parent e943f07a85
commit 93ffb85b3d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
rpc/endpoints.go
View File

@ -22,8 +22,9 @@ import (
"github.com/ethereum/go-ethereum/log" "github.com/ethereum/go-ethereum/log"
) )
// checkModuleAvailability check that all names given in modules are actually // checkModuleAvailability checks that all names given in modules are actually
// available API services. // available API services. It assumes that the MetadataApi module ("rpc") is always available;
// the registration of this "rpc" module happens in NewServer() and is thus common to all endpoints.
func checkModuleAvailability(modules []string, apis []API) (bad, available []string) { func checkModuleAvailability(modules []string, apis []API) (bad, available []string) {
availableSet := make(map[string]struct{}) availableSet := make(map[string]struct{})
for _, api := range apis { for _, api := range apis {
@ -33,7 +34,7 @@ func checkModuleAvailability(modules []string, apis []API) (bad, available []str
} }
} }
for _, name := range modules { for _, name := range modules {
if _, ok := availableSet[name]; !ok { if _, ok := availableSet[name]; !ok && name != MetadataApi {
bad = append(bad, name) bad = append(bad, name)
} }
} }