roysc/plugeth
1
0
Fork 0
forked from cerc-io/plugeth
Code Pull Requests Activity

p2p/simulations: fix unlikely crash in probabilistic connect (#23200)

Browse Source 
When the nodeCount is less than 10, it will panic with the out of bound error.
How about we just skip this round, when rand1 and rand2 are equal?
This commit is contained in:
Evolution404 2021-07-29 22:03:50 +08:00 committed by GitHub
parent b157bae2c9
commit 8f11d279d2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
p2p/simulations/mocker.go
View File

@ -123,20 +123,12 @@ func probabilistic(net *Network, quit chan struct{}, nodeCount int) {
randWait := time.Duration(rand.Intn(5000)+1000) * time.Millisecond randWait := time.Duration(rand.Intn(5000)+1000) * time.Millisecond
rand1 := rand.Intn(nodeCount - 1) rand1 := rand.Intn(nodeCount - 1)
rand2 := rand.Intn(nodeCount - 1) rand2 := rand.Intn(nodeCount - 1)
if rand1 < rand2 { if rand1 <= rand2 {
lowid = rand1 lowid = rand1
highid = rand2 highid = rand2
} else if rand1 > rand2 { } else if rand1 > rand2 {
highid = rand1 highid = rand1
lowid = rand2 lowid = rand2
} else {
if rand1 == 0 {
rand2 = 9
} else if rand1 == 9 {
rand1 = 0
}
lowid = rand1
highid = rand2
} }
var steps = highid - lowid var steps = highid - lowid
wg.Add(steps) wg.Add(steps)