Merge pull request #24905 from holiman/fix_has

ethdb/remotedb: fix flawed check in Has/HasAncient
This commit is contained in:
Péter Szilágyi 2022-05-19 08:25:34 +03:00 committed by GitHub
commit 7bcbbbf836
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -37,10 +37,10 @@ type Database struct {
func (db *Database) Has(key []byte) (bool, error) { func (db *Database) Has(key []byte) (bool, error) {
if _, err := db.Get(key); err != nil { if _, err := db.Get(key); err != nil {
return true, nil
}
return false, nil return false, nil
} }
return true, nil
}
func (db *Database) Get(key []byte) ([]byte, error) { func (db *Database) Get(key []byte) ([]byte, error) {
var resp hexutil.Bytes var resp hexutil.Bytes
@ -53,10 +53,10 @@ func (db *Database) Get(key []byte) ([]byte, error) {
func (db *Database) HasAncient(kind string, number uint64) (bool, error) { func (db *Database) HasAncient(kind string, number uint64) (bool, error) {
if _, err := db.Ancient(kind, number); err != nil { if _, err := db.Ancient(kind, number); err != nil {
return true, nil
}
return false, nil return false, nil
} }
return true, nil
}
func (db *Database) Ancient(kind string, number uint64) ([]byte, error) { func (db *Database) Ancient(kind string, number uint64) ([]byte, error) {
var resp hexutil.Bytes var resp hexutil.Bytes