From 7b3e3d549ed3af9abad6251b9bf17c526ee444ba Mon Sep 17 00:00:00 2001 From: Matthew Halpern Date: Mon, 18 Feb 2019 03:31:22 -0800 Subject: [PATCH] node: prefer nil slices over zero-length slices (#19083) --- node/config.go | 2 +- node/node.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/node/config.go b/node/config.go index ff0725aab..2f871e478 100644 --- a/node/config.go +++ b/node/config.go @@ -466,7 +466,7 @@ func makeAccountManager(conf *Config) (*accounts.Manager, string, error) { return nil, "", err } // Assemble the account manager and supported backends - backends := []accounts.Backend{} + var backends []accounts.Backend if len(conf.ExternalSigner) > 0 { log.Info("Using external signer", "url", conf.ExternalSigner) if extapi, err := external.NewExternalBackend(conf.ExternalSigner); err == nil { diff --git a/node/node.go b/node/node.go index f267cdc46..9227bf6bb 100644 --- a/node/node.go +++ b/node/node.go @@ -220,7 +220,7 @@ func (n *Node) Start() error { return convertFileLockError(err) } // Start each of the services - started := []reflect.Type{} + var started []reflect.Type for kind, service := range services { // Start the next service, stopping all previous upon failure if err := service.Start(running); err != nil {