roysc/plugeth
1
0
Fork 0
forked from cerc-io/plugeth
Code Pull Requests Activity

les, tests: fix vflux fuzzer by removing unnecessary panic (#24537)

Browse Source
This commit is contained in:
rjl493456442 2022-03-16 18:13:10 +08:00 committed by GitHub
parent 8d99fedeae
commit 7a80cf6543
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
les/vflux/server/clientpool.go
View File

@ -34,7 +34,7 @@ import (
var ( var (
ErrNotConnected = errors.New("client not connected") ErrNotConnected = errors.New("client not connected")
ErrNoPriority = errors.New("priority too low to raise capacity") ErrNoPriority = errors.New("priority too low to raise capacity")
ErrCantFindMaximum = errors.New("Unable to find maximum allowed capacity") ErrCantFindMaximum = errors.New("unable to find maximum allowed capacity")
) )
// ClientPool implements a client database that assigns a priority to each client // ClientPool implements a client database that assigns a priority to each client
@ -177,7 +177,7 @@ func (cp *ClientPool) Unregister(peer clientPeer) {
cp.ns.SetField(peer.Node(), cp.setup.clientField, nil) cp.ns.SetField(peer.Node(), cp.setup.clientField, nil)
} }
// setConnectedBias sets the connection bias, which is applied to already connected clients // SetConnectedBias sets the connection bias, which is applied to already connected clients
// So that already connected client won't be kicked out very soon and we can ensure all // So that already connected client won't be kicked out very soon and we can ensure all
// connected clients can have enough time to request or sync some data. // connected clients can have enough time to request or sync some data.
func (cp *ClientPool) SetConnectedBias(bias time.Duration) { func (cp *ClientPool) SetConnectedBias(bias time.Duration) {

4
tests/fuzzers/vflux/clientpool-fuzzer.go
View File

@ -267,9 +267,7 @@ func FuzzClientPool(input []byte) int {
bias = f.randomDelay() bias = f.randomDelay()
requested = f.randomBool() requested = f.randomBool()
) )
if _, err := pool.SetCapacity(f.peers[index].node, reqCap, bias, requested); err == vfs.ErrCantFindMaximum { pool.SetCapacity(f.peers[index].node, reqCap, bias, requested)
panic(nil)
}
doLog("Set capacity", "id", f.peers[index].node.ID(), "reqcap", reqCap, "bias", bias, "requested", requested) doLog("Set capacity", "id", f.peers[index].node.ID(), "reqcap", reqCap, "bias", bias, "requested", requested)
case 7: case 7:
index := f.randomByte() index := f.randomByte()