roysc/plugeth
1
0
Fork 0
forked from cerc-io/plugeth
Code Pull Requests Activity

p2p/nat: skip TestUPNP in non-CI environments if discover fails (#22877)

Browse Source 
Fixes #21476
This commit is contained in:
meowsbits 2021-05-25 15:37:30 -05:00 committed by GitHub
parent 51b32cc7e4
commit 750115ff39
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
p2p/nat/natupnp_test.go
View File

@ -21,6 +21,7 @@ import (
"io" "io"
"net" "net"
"net/http" "net/http"
"os"
"runtime" "runtime"
"strings" "strings"
"testing" "testing"
@ -162,7 +163,11 @@ func TestUPNP_DDWRT(t *testing.T) {
// Attempt to discover the fake device. // Attempt to discover the fake device.
discovered := discoverUPnP() discovered := discoverUPnP()
if discovered == nil { if discovered == nil {
t.Fatalf("not discovered") if os.Getenv("CI") != "" {
t.Fatalf("not discovered")
} else {
t.Skipf("UPnP not discovered (known issue, see https://github.com/ethereum/go-ethereum/issues/21476)")
}
} }
upnp, _ := discovered.(*upnp) upnp, _ := discovered.(*upnp)
if upnp.service != "IGDv1-IP1" { if upnp.service != "IGDv1-IP1" {