roysc/plugeth
1
0
Fork 0
forked from cerc-io/plugeth
Code Pull Requests Activity

ethdb: return copied value from MemDatabase.Get (#14958)

Browse Source
This commit is contained in:
gary rong 2017-08-11 18:41:49 +08:00 committed by Felix Lange
parent 17ce0a37de
commit 73c5aba21f
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
ethdb/database_test.go
View File

@ -94,6 +94,21 @@ func testPutGet(db ethdb.Database, t *testing.T) {
}
}
for _, v := range test_values {
orig, err := db.Get([]byte(v))
if err != nil {
t.Fatalf("get failed: %v", err)
}
orig[0] = byte(0xff)
data, err := db.Get([]byte(v))
if err != nil {
t.Fatalf("get failed: %v", err)
}
if !bytes.Equal(data, []byte("?")) {
t.Fatalf("get returned wrong result, got %q expected ?", string(data))
}
}
for _, v := range test_values {
err := db.Delete([]byte(v))
if err != nil {

2
ethdb/memory_database.go
View File

@ -50,7 +50,7 @@ func (db *MemDatabase) Get(key []byte) ([]byte, error) {
defer db.lock.RUnlock()
if entry, ok := db.db[string(key)]; ok {
return entry, nil
return common.CopyBytes(entry), nil
}
return nil, errors.New("not found")
}