From 52b1d0945774336a1c2164f873df3c0a72cacaee Mon Sep 17 00:00:00 2001 From: Wenbiao Zheng Date: Thu, 14 Jun 2018 18:46:43 +0800 Subject: [PATCH] core: reduce nesting in transaction pool code (#16980) --- core/tx_pool.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/core/tx_pool.go b/core/tx_pool.go index b0b55fcc2..9c958e3b6 100644 --- a/core/tx_pool.go +++ b/core/tx_pool.go @@ -815,11 +815,9 @@ func (pool *TxPool) addTxsLocked(txs []*types.Transaction, local bool) []error { for i, tx := range txs { var replace bool - if replace, errs[i] = pool.add(tx, local); errs[i] == nil { - if !replace { - from, _ := types.Sender(pool.signer, tx) // already validated - dirty[from] = struct{}{} - } + if replace, errs[i] = pool.add(tx, local); errs[i] == nil && !replace { + from, _ := types.Sender(pool.signer, tx) // already validated + dirty[from] = struct{}{} } } // Only reprocess the internal state if something was actually added