roysc/plugeth
1
0
Fork 0
forked from cerc-io/plugeth
Code Pull Requests Activity

graphql: return error if block from>to (#28393)

Browse Source 
As per discussion in ethereum/execution-apis#475
This commit is contained in:
Delweng 2023-10-23 23:25:26 +08:00 committed by GitHub
parent 3853f50082
commit 43e6a3c196
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
graphql/graphql.go
View File

@ -41,7 +41,8 @@ import (
) )
var ( var (
errBlockInvariant = errors.New("block objects must be instantiated with at least one of num or hash") errBlockInvariant = errors.New("block objects must be instantiated with at least one of num or hash")
errInvalidBlockRange = errors.New("invalid from and to block combination: from > to")
) )
type Long int64 type Long int64
@ -1333,7 +1334,7 @@ func (r *Resolver) Blocks(ctx context.Context, args struct {
to = rpc.BlockNumber(r.backend.CurrentBlock().Number.Int64()) to = rpc.BlockNumber(r.backend.CurrentBlock().Number.Int64())
} }
if to < from { if to < from {
return []*Block{}, nil return nil, errInvalidBlockRange
} }
var ret []*Block var ret []*Block
for i := from; i <= to; i++ { for i := from; i <= to; i++ {