roysc/plugeth
1
0
Fork 0
forked from cerc-io/plugeth
Code Pull Requests Activity

core/vm: Correct the Memory Gas Overflow condition

Browse Source 
previous overflow condition is too big to use.
0x7FFFFFFFF squre operation is overflowed uint64.

0x7FFFFFFFF^2 = 0x3F FFFF FFF0 0000 0001
This commit is contained in:
Liang Ma 2019-03-28 21:04:31 +00:00
parent 5b0d3fa393
commit 157f09e5b6
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/vm/gas_table.go
View File

@ -32,11 +32,11 @@ func memoryGasCost(mem *Memory, newMemSize uint64) (uint64, error) {
// The maximum that will fit in a uint64 is max_word_count - 1
// anything above that will result in an overflow.
// Additionally, a newMemSize which results in a
// newMemSizeWords larger than 0x7ffffffff will cause the square operation
// newMemSizeWords larger than 0xFFFFFFFF will cause the square operation
// to overflow.
// The constant 0xffffffffe0 is the highest number that can be used without
// The constant 0x1FFFFFFFE0 is the highest number that can be used without
// overflowing the gas calculation
if newMemSize > 0xffffffffe0 {
if newMemSize > 0x1FFFFFFFE0 {
return 0, errGasUintOverflow
}