roysc/plugeth
1
0
Fork 0
forked from cerc-io/plugeth
Code Pull Requests Activity

Merge pull request #24652 from karalabe/block-fetcher-timeouts

Browse Source 
eth/fetcher: if peers never respond, drop them
This commit is contained in:
Péter Szilágyi 2022-04-06 10:43:18 +03:00 committed by GitHub
commit 111a1b73cf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 30 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
eth/fetcher/block_fetcher.go
View File

@ -477,10 +477,21 @@ func (f *BlockFetcher) loop() {
} }
defer req.Close() defer req.Close()
res := <-resCh timeout := time.NewTimer(2 * fetchTimeout) // 2x leeway before dropping the peer
res.Done <- nil defer timeout.Stop()
f.FilterHeaders(peer, *res.Res.(*eth.BlockHeadersPacket), time.Now().Add(res.Time)) select {
case res := <-resCh:
res.Done <- nil
f.FilterHeaders(peer, *res.Res.(*eth.BlockHeadersPacket), time.Now().Add(res.Time))
case <-timeout.C:
// The peer didn't respond in time. The request
// was already rescheduled at this point, we were
// waiting for a catchup. With an unresponsive
// peer however, it's a protocol violation.
f.dropPeer(peer)
}
}(hash) }(hash)
} }
}(peer) }(peer)
@ -523,11 +534,23 @@ func (f *BlockFetcher) loop() {
} }
defer req.Close() defer req.Close()
res := <-resCh timeout := time.NewTimer(2 * fetchTimeout) // 2x leeway before dropping the peer
res.Done <- nil defer timeout.Stop()
txs, uncles := res.Res.(*eth.BlockBodiesPacket).Unpack() select {
f.FilterBodies(peer, txs, uncles, time.Now()) case res := <-resCh:
res.Done <- nil
txs, uncles := res.Res.(*eth.BlockBodiesPacket).Unpack()
f.FilterBodies(peer, txs, uncles, time.Now())
case <-timeout.C:
// The peer didn't respond in time. The request
// was already rescheduled at this point, we were
// waiting for a catchup. With an unresponsive
// peer however, it's a protocol violation.
f.dropPeer(peer)
}
}(peer, hashes) }(peer, hashes)
} }
// Schedule the next fetch if blocks are still pending // Schedule the next fetch if blocks are still pending