roysc/plugeth
1
0
Fork 0
forked from cerc-io/plugeth
Code Pull Requests Activity

p2p/discv5, p2p/testing: add missing Timer.Stop calls in tests (#20869)

Browse Source
This commit is contained in:
ucwong 2020-04-02 22:03:40 +08:00 committed by GitHub
parent 37d6357806
commit 0c359e4b9a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
p2p/discv5/sim_test.go
View File

@ -43,6 +43,7 @@ func TestSimRandomResolve(t *testing.T) {
// A new node joins every 10s. // A new node joins every 10s.
launcher := time.NewTicker(10 * time.Second) launcher := time.NewTicker(10 * time.Second)
defer launcher.Stop()
go func() { go func() {
for range launcher.C { for range launcher.C {
net := sim.launchNode(false) net := sim.launchNode(false)
@ -55,7 +56,6 @@ func TestSimRandomResolve(t *testing.T) {
}() }()
time.Sleep(3 * time.Hour) time.Sleep(3 * time.Hour)
launcher.Stop()
sim.shutdown() sim.shutdown()
sim.printStats() sim.printStats()
} }
@ -196,6 +196,7 @@ func randomResolves(t *testing.T, s *simulation, net *Network) {
} }
timer := time.NewTimer(randtime()) timer := time.NewTimer(randtime())
defer timer.Stop()
for { for {
select { select {
case <-timer.C: case <-timer.C:

1
p2p/testing/protocolsession.go
View File

@ -242,6 +242,7 @@ func (s *ProtocolSession) testExchange(e Exchange) error {
t = 2000 * time.Millisecond t = 2000 * time.Millisecond
} }
alarm := time.NewTimer(t) alarm := time.NewTimer(t)
defer alarm.Stop()
select { select {
case err := <-errc: case err := <-errc:
return err return err