cmd/geth: limit pendingTransactions to owned accounts.

This commit is contained in:
obscuren 2015-05-06 14:53:20 +02:00
parent eb4029257a
commit 05ac1209c7

View File

@ -16,6 +16,7 @@ import (
"github.com/ethereum/go-ethereum/rpc" "github.com/ethereum/go-ethereum/rpc"
"github.com/ethereum/go-ethereum/xeth" "github.com/ethereum/go-ethereum/xeth"
"github.com/robertkrimen/otto" "github.com/robertkrimen/otto"
"gopkg.in/fatih/set.v0"
) )
/* /*
@ -25,7 +26,7 @@ node admin bindings
func (js *jsre) adminBindings() { func (js *jsre) adminBindings() {
ethO, _ := js.re.Get("eth") ethO, _ := js.re.Get("eth")
eth := ethO.Object() eth := ethO.Object()
eth.Set("transactions", js.transactions) eth.Set("pendingTransactions", js.pendingTransactions)
eth.Set("resend", js.resend) eth.Set("resend", js.resend)
js.re.Set("admin", struct{}{}) js.re.Set("admin", struct{}{})
@ -80,43 +81,30 @@ func (js *jsre) getBlock(call otto.FunctionCall) (*types.Block, error) {
return nil, errors.New("requires block number or block hash as argument") return nil, errors.New("requires block number or block hash as argument")
} }
type tx struct { func (js *jsre) pendingTransactions(call otto.FunctionCall) otto.Value {
tx *types.Transaction
To string
From string
Nonce string
Value string
Data string
GasLimit string
GasPrice string
}
func newTx(t *types.Transaction) *tx {
from, _ := t.From()
var to string
if t := t.To(); t != nil {
to = t.Hex()
}
return &tx{
tx: t,
To: to,
From: from.Hex(),
Value: t.Amount.String(),
Nonce: strconv.Itoa(int(t.Nonce())),
Data: "0x" + common.Bytes2Hex(t.Data()),
GasLimit: t.GasLimit.String(),
GasPrice: t.GasPrice().String(),
}
}
func (js *jsre) transactions(call otto.FunctionCall) otto.Value {
txs := js.ethereum.TxPool().GetTransactions() txs := js.ethereum.TxPool().GetTransactions()
ltxs := make([]*tx, len(txs)) // grab the accounts from the account manager. This will help with determening which
for i, tx := range txs { // transactions should be returned.
ltxs[i] = newTx(tx) accounts, err := js.ethereum.AccountManager().Accounts()
if err != nil {
fmt.Println(err)
return otto.UndefinedValue()
}
// Add the accouns to a new set
accountSet := set.New()
for _, account := range accounts {
accountSet.Add(common.BytesToAddress(account.Address))
}
//ltxs := make([]*tx, len(txs))
var ltxs []*tx
for _, tx := range txs {
// no need to check err
if from, _ := tx.From(); accountSet.Has(from) {
ltxs = append(ltxs, newTx(tx))
}
} }
return js.re.ToVal(ltxs) return js.re.ToVal(ltxs)
@ -504,3 +492,35 @@ func (js *jsre) dumpBlock(call otto.FunctionCall) otto.Value {
return js.re.ToVal(dump) return js.re.ToVal(dump)
} }
// internal transaction type which will allow us to resend transactions using `eth.resend`
type tx struct {
tx *types.Transaction
To string
From string
Nonce string
Value string
Data string
GasLimit string
GasPrice string
}
func newTx(t *types.Transaction) *tx {
from, _ := t.From()
var to string
if t := t.To(); t != nil {
to = t.Hex()
}
return &tx{
tx: t,
To: to,
From: from.Hex(),
Value: t.Amount.String(),
Nonce: strconv.Itoa(int(t.Nonce())),
Data: "0x" + common.Bytes2Hex(t.Data()),
GasLimit: t.GasLimit.String(),
GasPrice: t.GasPrice().String(),
}
}