deep-stack/wallet-connect-web-examples
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(api): use /account-balance endpoint instead of /account-assets

Browse Source 
There seems to be a weird race condition on the `/account-assets`
endpoint when handling two different requests for the same chainId.

Reproduction:
https://codesandbox.io/s/ethereum-api-race-condition-repro-f24x4t?file=/src/index.js
This commit is contained in:
Ben Kremer 2022-02-21 17:49:32 +01:00
parent c4b93e771a
commit 7e76cb79d1
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dapps/react-dapp-v2/src/contexts/ClientContext.tsx
View File

@ -18,7 +18,7 @@ import {
DEFAULT_PROJECT_ID, DEFAULT_PROJECT_ID,
DEFAULT_RELAY_URL, DEFAULT_RELAY_URL,
} from "../constants"; } from "../constants";
import { AccountBalances, apiGetAccountAssets } from "../helpers"; import { AccountBalances, apiGetAccountBalance } from "../helpers";
import { ERROR, getAppMetadata } from "@walletconnect/utils"; import { ERROR, getAppMetadata } from "@walletconnect/utils";
/** /**
@ -73,8 +73,8 @@ export function ClientContextProvider({ children }: { children: ReactNode | Reac
_accounts.map(async account => { _accounts.map(async account => {
const [namespace, reference, address] = account.split(":"); const [namespace, reference, address] = account.split(":");
const chainId = `${namespace}:${reference}`; const chainId = `${namespace}:${reference}`;
const assets = await apiGetAccountAssets(address, chainId); const assets = await apiGetAccountBalance(address, chainId);
return { account, assets }; return { account, assets: [assets] };
}), }),
); );

9
dapps/react-dapp-v2/src/helpers/api.ts
View File

@ -19,6 +19,15 @@ export async function apiGetAccountAssets(address: string, chainId: string): Pro
return result; return result;
} }
export async function apiGetAccountBalance(address: string, chainId: string): Promise<AssetData> {
const ethChainId = chainId.split(":")[1];
const response = await ethereumApi.get(
`/account-balance?address=${address}&chainId=${ethChainId}`,
);
const { result } = response.data;
return result;
}
export async function apiGetAccountTransactions( export async function apiGetAccountTransactions(
address: string, address: string,
chainId: string, chainId: string,