From a085ca8756760588839d52908d8a3fc3b04b02c5 Mon Sep 17 00:00:00 2001 From: Prathamesh Musale Date: Thu, 30 Jan 2025 11:48:56 +0530 Subject: [PATCH] Fix function arg type --- .../deploy/webapp/deploy_webapp_from_registry.py | 4 ++-- stack_orchestrator/deploy/webapp/util.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/stack_orchestrator/deploy/webapp/deploy_webapp_from_registry.py b/stack_orchestrator/deploy/webapp/deploy_webapp_from_registry.py index 228cd7a8..24a529c2 100644 --- a/stack_orchestrator/deploy/webapp/deploy_webapp_from_registry.py +++ b/stack_orchestrator/deploy/webapp/deploy_webapp_from_registry.py @@ -251,8 +251,8 @@ def process_app_deployment_request( app_deployment_lrn, dns_record, dns_lrn, - dns_value, deployment_dir, + dns_value, app_deployment_request, webapp_deployer_record, logger, @@ -306,7 +306,7 @@ def dump_known_requests(filename, requests, status="SEEN"): help="How to handle requests with an FQDN: prohibit, allow, preexisting", default="prohibit", ) -@click.option("--ip", help="IP address of the k8s deployment (to be set in DNS record)") +@click.option("--ip", help="IP address of the k8s deployment (to be set in DNS record)", default=None) @click.option("--record-namespace-dns", help="eg, lrn://laconic/dns", required=True) @click.option( "--record-namespace-deployments", diff --git a/stack_orchestrator/deploy/webapp/util.py b/stack_orchestrator/deploy/webapp/util.py index 1b52cab0..991dd249 100644 --- a/stack_orchestrator/deploy/webapp/util.py +++ b/stack_orchestrator/deploy/webapp/util.py @@ -688,8 +688,8 @@ def publish_deployment( deployment_lrn, dns_record, dns_lrn, - dns_value: str | None, deployment_dir, + dns_value=None, app_deployment_request=None, webapp_deployer_record=None, logger=None,