Update UI to take environment variables from user (#6)

Part of [Service provider auctions for web deployments](https://www.notion.so/Service-provider-auctions-for-web-deployments-104a6b22d47280dbad51d28aa3a91d75)

- Take environment variables from the user in the `Configure` deployment step

Co-authored-by: Isha Venikar <ishavenikar@Ishas-MacBook-Air.local>
Co-authored-by: IshaVenikar <ishavenikar7@gmail.com>
Reviewed-on: cerc-io/snowballtools-base#6

packages/frontend/src/components/projects/create/Configure.tsx

@@ -1,8 +1,9 @@
 import { useCallback, useState } from 'react';
-import { useForm, Controller, SubmitHandler } from 'react-hook-form';
+import { useForm, Controller } from 'react-hook-form';
+import { FormProvider, FieldValues } from 'react-hook-form';
 import { useNavigate, useSearchParams } from 'react-router-dom';
 import { useMediaQuery } from 'usehooks-ts';
-import { AuctionParams } from 'gql-client';
+import { AddEnvironmentVariableInput, AuctionParams } from 'gql-client';
 
 import {
   ArrowRightCircleFilledIcon,
@@ -14,15 +15,20 @@ import { Select, SelectOption } from 'components/shared/Select';
 import { Input } from 'components/shared/Input';
 import { useToast } from 'components/shared/Toast';
 import { useGQLClient } from '../../../context/GQLClientContext';
+import EnvironmentVariablesForm from 'pages/org-slug/projects/id/settings/EnvironmentVariablesForm';
+import { EnvironmentVariablesFormValues } from 'types/types';
 
-type ConfigureFormValues = {
+type ConfigureDeploymentFormValues = {
   option: string;
   lrn?: string;
   numProviders?: number;
   maxPrice?: string;
 };
 
+type ConfigureFormValues = ConfigureDeploymentFormValues & EnvironmentVariablesFormValues;
+
 const Configure = () => {
+  const [isLoading, setIsLoading] = useState(false);
   const [searchParams] = useSearchParams();
   const templateId = searchParams.get('templateId');
   const queryParams = new URLSearchParams(location.search);
@@ -40,96 +46,147 @@ const Configure = () => {
   const { toast, dismiss } = useToast();
   const client = useGQLClient();
 
-  const [isLoading, setIsLoading] = useState(false);
-  const { handleSubmit, control, watch } = useForm<ConfigureFormValues>({
+  const methods = useForm<ConfigureFormValues>({
     defaultValues: { option: 'LRN' },
   });
 
-  const selectedOption = watch('option');
+  const selectedOption = methods.watch('option');
 
   const isTabletView = useMediaQuery('(min-width: 720px)'); // md:
   const buttonSize = isTabletView ? { size: 'lg' as const } : {};
 
-  const onSubmit: SubmitHandler<ConfigureFormValues> = useCallback(
-    async (data) => {
-      setIsLoading(true);
+  const createProject = async (data: FieldValues, envVariables: AddEnvironmentVariableInput[]): Promise<string> => {
+    setIsLoading(true);
+    let projectId: string | null = null;
 
-      try {
-        let lrn: string | undefined;
-        let auctionParams: AuctionParams | undefined;
+    try {
+      let lrn: string | undefined;
+      let auctionParams: AuctionParams | undefined;
 
-        if (data.option === 'LRN') {
-          lrn = data.lrn;
-        } else if (data.option === 'Auction') {
-          auctionParams = {
-            numProviders: Number(data.numProviders!),
-            maxPrice: (data.maxPrice!).toString(),
-          };
-        }
+      if (data.option === 'LRN') {
+        lrn = data.lrn;
+      } else if (data.option === 'Auction') {
+        auctionParams = {
+          numProviders: Number(data.numProviders!),
+          maxPrice: (data.maxPrice!).toString(),
+        };
+      }
 
-        if (templateId) {
-          // Template-based project creation
-          const projectData: any = {
-            templateOwner,
-            templateRepo,
-            owner,
-            name,
-            isPrivate,
-          };
+      if (templateId) {
+        const projectData: any = {
+          templateOwner,
+          templateRepo,
+          owner,
+          name,
+          isPrivate,
+        };
 
-          const { addProjectFromTemplate } = await client.addProjectFromTemplate(
-            orgSlug!,
-            projectData,
-            lrn,
-            auctionParams
-          );
+        const { addProjectFromTemplate } = await client.addProjectFromTemplate(
+          orgSlug!,
+          projectData,
+          lrn,
+          auctionParams,
+          envVariables
+        );
 
-          data.option === 'Auction'
-            ? navigate(
-              `/${orgSlug}/projects/create/success/${addProjectFromTemplate.id}?isAuction=true`,
-            )
-            : navigate(
-              `/${orgSlug}/projects/create/template/deploy?projectId=${addProjectFromTemplate.id}&templateId=${templateId}`
-            );
-        } else {
-          const { addProject } = await client.addProject(
-            orgSlug!,
-            {
-              name: fullName!,
-              prodBranch: defaultBranch!,
-              repository: fullName!,
-              template: 'webapp',
-            },
-            lrn,
-            auctionParams
-          );
+        projectId = addProjectFromTemplate.id;
+      } else {
+        const { addProject } = await client.addProject(
+          orgSlug!,
+          {
+            name: fullName!,
+            prodBranch: defaultBranch!,
+            repository: fullName!,
+            template: 'webapp',
+          },
+          lrn,
+          auctionParams,
+          envVariables
+        );
 
-          data.option === 'Auction'
-            ? navigate(
-              `/${orgSlug}/projects/create/success/${addProject.id}?isAuction=true`
-            )
-            : navigate(
-              `/${orgSlug}/projects/create/deploy?projectId=${addProject.id}`
-            );
-        }
-      } catch (error) {
-        console.error('Error creating project:', error);
+        projectId = addProject.id;
+      }
+    } catch (error) {
+      console.error('Error creating project:', error);
+      toast({
+        id: 'error-creating-project',
+        title: 'Error creating project',
+        variant: 'error',
+        onDismiss: dismiss,
+      });
+    } finally {
+      setIsLoading(false);
+    }
+
+    if (projectId) {
+      return projectId;
+    } else {
+      throw new Error('Project creation failed');
+    }
+  };
+
+  const handleFormSubmit = useCallback(
+    async (createFormData: FieldValues) => {
+      const environmentVariables = createFormData.variables.map((variable: any) => {
+        return {
+          key: variable.key,
+          value: variable.value,
+          environments: Object.entries(createFormData.environment)
+            .filter(([, value]) => value === true)
+            .map(([key]) => key.charAt(0).toUpperCase() + key.slice(1)),
+        };
+      });
+
+      const projectId = await createProject(createFormData, environmentVariables);
+
+      const { environmentVariables: isEnvironmentVariablesAdded } =
+        await client.getEnvironmentVariables(projectId);
+
+      if (isEnvironmentVariablesAdded.length > 0) {
         toast({
-          id: 'error-creating-project',
-          title: 'Error creating project',
+          id:
+            createFormData.variables.length > 1
+              ? 'env_variable_added'
+              : 'env_variables_added',
+          title:
+            createFormData.variables.length > 1
+              ? `${createFormData.variables.length} variables added`
+              : `Variable added`,
+          variant: 'success',
+          onDismiss: dismiss,
+        });
+      } else {
+        toast({
+          id: 'env_variables_not_added',
+          title: 'Environment variables not added',
           variant: 'error',
           onDismiss: dismiss,
         });
-      } finally {
-        setIsLoading(false);
+      }
+      if (templateId) {
+        createFormData.option === 'Auction'
+          ? navigate(
+            `/${orgSlug}/projects/create/success/${projectId}?isAuction=true`,
+          )
+          : navigate(
+            `/${orgSlug}/projects/create/template/deploy?projectId=${projectId}&templateId=${templateId}`
+          );
+      } else {
+        createFormData.option === 'Auction'
+          ? navigate(
+            `/${orgSlug}/projects/create/success/${projectId}?isAuction=true`
+          )
+          : navigate(
+            `/${orgSlug}/projects/create/deploy?projectId=${projectId}`
+          );
       }
     },
-    [client, isPrivate, templateId, navigate, dismiss, toast]
+    [client, createProject, dismiss, toast]
   );
 
   return (
-    <div className="space-y-7">
-      <div className="flex justify-between">
+    <div className="space-y-7 px-4 py-6">
+      <div className="flex justify-between mb-6">
         <div className="space-y-1.5">
           <Heading as="h4" className="md:text-lg font-medium">
             Configure deployment
@@ -142,99 +199,111 @@ const Configure = () => {
         </div>
       </div>
 
-      <form onSubmit={handleSubmit(onSubmit)}>
-        <div className="flex flex-col gap-4 lg:gap-7 w-full">
-          <div className="flex flex-col justify-start gap-3">
-            <Controller
-              name="option"
-              control={control}
-              render={({ field: { value, onChange } }) => (
-                <Select
-                  label="Configuration Options"
-                  value={
-                    {
-                      value: value || 'LRN',
-                      label: value === 'Auction' ? 'Create Auction' : 'Deployer LRN',
-                    } as SelectOption
-                  }
-                  onChange={(value) => onChange((value as SelectOption).value)}
-                  options={[
-                    { value: 'LRN', label: 'Deployer LRN' },
-                    { value: 'Auction', label: 'Create Auction' },
-                  ]}
-                />
-              )}
-            />
-          </div>
-
-          {selectedOption === 'LRN' && (
-            <div className="flex flex-col justify-start gap-3">
-              <Heading as="h5" className="text-sm font-sans text-elements-low-em">
-                The app will be deployed by the configured deployer
-              </Heading>
-              <span className="text-sm text-elements-high-em">
-                Enter LRN for deployer
-              </span>
+      <div className="flex flex-col gap-6 lg:gap-8 w-full">
+        <FormProvider {...methods}>
+          <form onSubmit={methods.handleSubmit(handleFormSubmit)}>
+            <div className="flex flex-col justify-start gap-4 mb-6">
               <Controller
-                name="lrn"
-                control={control}
+                name="option"
+                control={methods.control}
                 render={({ field: { value, onChange } }) => (
-                  <Input value={value} onChange={onChange} />
+                  <Select
+                    label="Configuration Options"
+                    value={
+                      {
+                        value: value || 'LRN',
+                        label: value === 'Auction' ? 'Create Auction' : 'Deployer LRN',
+                      } as SelectOption
+                    }
+                    onChange={(value) => onChange((value as SelectOption).value)}
+                    options={[
+                      { value: 'LRN', label: 'Deployer LRN' },
+                      { value: 'Auction', label: 'Create Auction' },
+                    ]}
+                  />
                 )}
               />
             </div>
-          )}
 
-          {selectedOption === 'Auction' && (
-            <>
-              <div className="flex flex-col justify-start gap-3">
+            {selectedOption === 'LRN' && (
+              <div className="flex flex-col justify-start gap-4 mb-6">
                 <Heading as="h5" className="text-sm font-sans text-elements-low-em">
-                  Set the number of deployers and maximum price for each deployment
+                  The app will be deployed by the configured deployer
                 </Heading>
                 <span className="text-sm text-elements-high-em">
-                  Number of Deployers
+                  Enter LRN for deployer
                 </span>
                 <Controller
-                  name="numProviders"
-                  control={control}
+                  name="lrn"
+                  control={methods.control}
+                  rules={{ required: true }}
                   render={({ field: { value, onChange } }) => (
-                    <Input type="number" value={value} onChange={onChange} />
+                    <Input value={value} onChange={onChange} />
                   )}
                 />
               </div>
-              <div className="flex flex-col justify-start gap-3">
-                <span className="text-sm text-elements-high-em">
-                  Maximum Price (alnt)
-                </span>
-                <Controller
-                  name="maxPrice"
-                  control={control}
-                  render={({ field: { value, onChange } }) => (
-                    <Input type="number" value={value} onChange={onChange} />
-                  )}
-                />
-              </div>
-            </>
-          )}
+            )}
 
-          <div>
-            <Button
-              {...buttonSize}
-              type="submit"
-              disabled={isLoading}
-              rightIcon={
-                isLoading ? (
-                  <LoadingIcon className="animate-spin" />
-                ) : (
-                  <ArrowRightCircleFilledIcon />
-                )
-              }
-            >
-              {isLoading ? 'Deploying repo' : 'Deploy repo'}
-            </Button>
-          </div>
-        </div>
-      </form>
+            {selectedOption === 'Auction' && (
+              <>
+                <div className="flex flex-col justify-start gap-4 mb-6">
+                  <Heading as="h5" className="text-sm font-sans text-elements-low-em">
+                    Set the number of deployers and maximum price for each deployment
+                  </Heading>
+                  <span className="text-sm text-elements-high-em">
+                    Number of Deployers
+                  </span>
+                  <Controller
+                    name="numProviders"
+                    control={methods.control}
+                    rules={{ required: true }}
+                    render={({ field: { value, onChange } }) => (
+                      <Input type="number" value={value} onChange={onChange} />
+                    )}
+                  />
+                </div>
+                <div className="flex flex-col justify-start gap-4 mb-6">
+                  <span className="text-sm text-elements-high-em">
+                    Maximum Price (alnt)
+                  </span>
+                  <Controller
+                    name="maxPrice"
+                    control={methods.control}
+                    rules={{ required: true }}
+                    render={({ field: { value, onChange } }) => (
+                      <Input type="number" value={value} onChange={onChange} />
+                    )}
+                  />
+                </div>
+              </>
+            )}
+
+            <Heading as="h4" className="md:text-lg font-medium mb-3">
+              Environment Variables
+            </Heading>
+            <div className="p-4 bg-slate-100 rounded-lg mb-6">
+              <EnvironmentVariablesForm />
+            </div>
+
+            <div>
+              <Button
+                {...buttonSize}
+                type="submit"
+                disabled={isLoading}
+                rightIcon={
+                  isLoading ? (
+                    <LoadingIcon className="animate-spin" />
+                  ) : (
+                    <ArrowRightCircleFilledIcon />
+                  )
+                }
+              >
+                {isLoading ? 'Deploying repo' : 'Deploy repo'}
+              </Button>
+            </div>
+          </form>
+        </FormProvider>
+      </div>
     </div>
   );
 };

packages/frontend/src/components/projects/create/RepositoryList/RepositoryList.tsx

@@ -64,9 +64,9 @@ export const RepositoryList = () => {
 
         // Check if selected account is an organization
         if (selectedAccount.value === gitUser.login) {
-          query = query + ` user:${selectedAccount}`;
+          query = query + ` user:${selectedAccount.value}`;
         } else {
-          query = query + ` org:${selectedAccount}`;
+          query = query + ` org:${selectedAccount.value}`;
         }
 
         const result = await octokit.rest.search.repos({

packages/frontend/src/pages/org-slug/projects/create/template/index.tsx

@@ -163,6 +163,7 @@ const CreateRepo = () => {
           <Controller
             name="repoName"
             control={control}
+            rules={{ required: true }}
             render={({ field: { value, onChange } }) => (
               <Input value={value} onChange={onChange} />
             )}
@@ -172,7 +173,7 @@ const CreateRepo = () => {
           <Controller
             name="isPrivate"
             control={control}
-            render={({}) => (
+            render={({ }) => (
               <Checkbox label="Make this repo private" disabled={true} />
             )}
           />

packages/frontend/src/pages/org-slug/projects/id/settings/EnvironmentVariables.tsx

@@ -1,22 +1,20 @@
-import { useCallback, useEffect, useMemo, useState } from 'react';
-import { useFieldArray, useForm } from 'react-hook-form';
+import { useCallback, useEffect, useState } from 'react';
 import { useParams } from 'react-router-dom';
 
-import { Collapse, Checkbox } from '@snowballtools/material-tailwind-react-fork';
+import { Collapse } from '@snowballtools/material-tailwind-react-fork';
 
-import AddEnvironmentVariableRow from 'components/projects/project/settings/AddEnvironmentVariableRow';
 import DisplayEnvironmentVariables from 'components/projects/project/settings/DisplayEnvironmentVariables';
 import { useGQLClient } from 'context/GQLClientContext';
 import { EnvironmentVariablesFormValues } from '../../../../../types';
 import HorizontalLine from 'components/HorizontalLine';
 import { Heading } from 'components/shared/Heading';
-import { Button } from 'components/shared/Button';
-// import { Checkbox } from 'components/shared/Checkbox';
 import { PlusIcon } from 'components/shared/CustomIcon';
-import { InlineNotification } from 'components/shared/InlineNotification';
 import { ProjectSettingContainer } from 'components/projects/project/settings/ProjectSettingContainer';
 import { useToast } from 'components/shared/Toast';
 import { Environment, EnvironmentVariable } from 'gql-client';
+import EnvironmentVariablesForm from './EnvironmentVariablesForm';
+import { FieldValues, FormProvider, useForm } from 'react-hook-form';
+import { Button } from 'components/shared';
 
 export const EnvironmentVariablesTabPanel = () => {
   const { id } = useParams();
@@ -27,13 +25,9 @@ export const EnvironmentVariablesTabPanel = () => {
     EnvironmentVariable[]
   >([]);
 
-  const {
-    handleSubmit,
-    register,
-    control,
-    reset,
-    formState: { isSubmitSuccessful, errors },
-  } = useForm<EnvironmentVariablesFormValues>({
+  const [createNewVariable, setCreateNewVariable] = useState(false);
+
+  const methods = useForm<EnvironmentVariablesFormValues>({
     defaultValues: {
       variables: [{ key: '', value: '' }],
       environment: {
@@ -43,21 +37,6 @@ export const EnvironmentVariablesTabPanel = () => {
       },
     },
   });
-  const [createNewVariable, setCreateNewVariable] = useState(false);
-
-  const { fields, append, remove } = useFieldArray({
-    name: 'variables',
-    control,
-    rules: {
-      required: 'Add at least 1 environment variables',
-    },
-  });
-
-  useEffect(() => {
-    if (isSubmitSuccessful) {
-      reset();
-    }
-  }, [isSubmitSuccessful, reset, id]);
 
   const getEnvironmentVariables = useCallback(
     (environment: Environment) => {
@@ -68,21 +47,6 @@ export const EnvironmentVariablesTabPanel = () => {
     [environmentVariables, id],
   );
 
-  const isFieldEmpty = useMemo(() => {
-    if (errors.variables) {
-      return fields.some((_, index) => {
-        if (
-          errors.variables![index]?.value?.type === 'required' ||
-          errors.variables![index]?.key?.type === 'required'
-        ) {
-          return true;
-        }
-      });
-    }
-
-    return false;
-  }, [fields, errors.variables, id]);
-
   const fetchEnvironmentVariables = useCallback(
     async (id: string | undefined) => {
       if (id) {
@@ -99,8 +63,8 @@ export const EnvironmentVariablesTabPanel = () => {
   }, [id]);
 
   const createEnvironmentVariablesHandler = useCallback(
-    async (createFormData: EnvironmentVariablesFormValues) => {
-      const environmentVariables = createFormData.variables.map((variable) => {
+    async (createFormData: FieldValues) => {
+      const environmentVariables = createFormData.variables.map((variable: any) => {
         return {
           key: variable.key,
           value: variable.value,
@@ -114,7 +78,7 @@ export const EnvironmentVariablesTabPanel = () => {
         await client.addEnvironmentVariables(id!, environmentVariables);
 
       if (isEnvironmentVariablesAdded) {
-        reset();
+        methods.reset();
         setCreateNewVariable((cur) => !cur);
 
         fetchEnvironmentVariables(id);
@@ -159,59 +123,10 @@ export const EnvironmentVariablesTabPanel = () => {
           </div>
         </Heading>
         <Collapse open={createNewVariable}>
-          <div className="p-4 bg-slate-100">
-            <form onSubmit={handleSubmit(createEnvironmentVariablesHandler)}>
-              {fields.map((field, index) => {
-                return (
-                  <AddEnvironmentVariableRow
-                    key={field.id}
-                    index={index}
-                    register={register}
-                    onDelete={() => remove(index)}
-                    isDeleteDisabled={fields.length === 1}
-                  />
-                );
-              })}
-              <div className="flex gap-1 p-2">
-                <Button
-                  size="md"
-                  onClick={() =>
-                    append({
-                      key: '',
-                      value: '',
-                    })
-                  }
-                >
-                  + Add variable
-                </Button>
-                {/* TODO: Implement import environment varible functionality */}
-                <Button size="md" disabled>
-                  Import .env
-                </Button>
-              </div>
-              {isFieldEmpty && (
-                <InlineNotification
-                  title="Please ensure no fields are empty before saving."
-                  variant="danger"
-                  size="md"
-                />
-              )}
-              <div className="flex gap-2 p-2">
-                <Checkbox
-                  label="Production"
-                  {...register(`environment.production`)}
-                  color="blue"
-                />
-                <Checkbox
-                  label="Preview"
-                  {...register(`environment.preview`)}
-                  color="blue"
-                />
-                <Checkbox
-                  label="Development"
-                  {...register(`environment.development`)}
-                  color="blue"
-                />
+          <FormProvider {...methods}>
+            <form onSubmit={methods.handleSubmit((data) => createEnvironmentVariablesHandler(data))}>
+              <div className="p-4 bg-slate-100">
+                <EnvironmentVariablesForm />
               </div>
               <div className="p-2">
                 <Button size="md" type="submit">
@@ -219,7 +134,7 @@ export const EnvironmentVariablesTabPanel = () => {
                 </Button>
               </div>
             </form>
-          </div>
+          </FormProvider>
         </Collapse>
       </div>
       <div className="p-2">

packages/frontend/src/pages/org-slug/projects/id/settings/EnvironmentVariablesForm.tsx

@@ -0,0 +1,76 @@
+import { useEffect, useMemo } from 'react';
+import { useFieldArray, useFormContext } from 'react-hook-form';
+
+// TODO: Use custom checkbox component
+import { Checkbox } from '@snowballtools/material-tailwind-react-fork';
+
+import { Button } from 'components/shared/Button';
+import { InlineNotification } from 'components/shared/InlineNotification';
+import AddEnvironmentVariableRow from 'components/projects/project/settings/AddEnvironmentVariableRow';
+import { EnvironmentVariablesFormValues } from 'types/types';
+
+const EnvironmentVariablesForm = () => {
+  const {
+    register,
+    control,
+    reset,
+    formState: { isSubmitSuccessful, errors },
+  } = useFormContext<EnvironmentVariablesFormValues>();
+  const { fields, append, remove } = useFieldArray({
+    name: 'variables',
+    control,
+  });
+
+  useEffect(() => {
+    if (isSubmitSuccessful) {
+      reset();
+    }
+  }, [isSubmitSuccessful, reset]);
+
+  const isFieldEmpty = useMemo(() => {
+    if (errors.variables) {
+      return fields.some((_, index) => {
+        if (
+          errors.variables![index]?.value?.type === 'required' ||
+          errors.variables![index]?.key?.type === 'required'
+        ) {
+          return true;
+        }
+      });
+    }
+
+    return false;
+  }, [fields, errors.variables]);
+
+  return (
+    <>
+      {fields.map((field, index) => (
+        <AddEnvironmentVariableRow
+          key={field.id}
+          index={index}
+          register={register}
+          onDelete={() => remove(index)}
+          isDeleteDisabled={fields.length === 0}
+        />
+      ))}
+      <div className="flex gap-1 p-2">
+        <Button size="md" onClick={() => append({ key: '', value: '' })}>
+          + Add variable
+        </Button>
+      </div>
+      {isFieldEmpty && (
+        <InlineNotification
+          title="Please ensure no fields are empty before saving."
+          variant="danger"
+        />
+      )}
+      <div className="flex gap-2 p-2">
+        <Checkbox label="Production" {...register('environment.production')} />
+        <Checkbox label="Preview" {...register('environment.preview')} />
+        <Checkbox label="Development" {...register('environment.development')} />
+      </div>
+    </>
+  );
+};
+
+export default EnvironmentVariablesForm;