From 6aad0e2506560f54f4a645897bbfdcf4d4eed356 Mon Sep 17 00:00:00 2001
From: IshaVenikar <ishavenikar7@gmail.com>
Date: Thu, 22 Aug 2024 12:31:04 +0530
Subject: [PATCH] Refactor Batch txs test

---
 src/index.test.ts     | 48 ++++++++++++++++++-------------------------
 src/testing/helper.ts | 15 +++++++++++++-
 2 files changed, 34 insertions(+), 29 deletions(-)

diff --git a/src/index.test.ts b/src/index.test.ts
index eeffcdc..c8d006a 100644
--- a/src/index.test.ts
+++ b/src/index.test.ts
@@ -1,7 +1,7 @@
 import { Account } from './account';
 import { DENOM } from './constants';
 import { Registry } from './index';
-import { getConfig } from './testing/helper';
+import { createTestAccounts, getConfig } from './testing/helper';
 
 const { chainId, rpcEndpoint, gqlEndpoint, privateKey, fee } = getConfig();
 
@@ -44,39 +44,31 @@ const registryTests = () => {
     expect(quantity).toBe('10000');
   });
 
-  test('Send batch txs.', async () => {
-    const accounts = await createAccounts(10);
+  describe('Batch txs', () => {
+    let accounts: Account[];
 
-    for (let i = 0; i < 10; i++) {
-      const amount = (10 ** (15 - i)).toString();
-      const fromAccount = i === 0 ? privateKey : accounts[i - 1].getPrivateKey();
+    beforeAll(async () => {
+      accounts = await createTestAccounts(10);
+      for (let i = 0; i < 10; i++) {
+        const amount = (10 ** (15 - i)).toString();
+        const fromAccount = i === 0 ? privateKey : accounts[i - 1].getPrivateKey();
 
-      await registry.sendCoins({ denom: DENOM, amount, destinationAddress: accounts[i].address }, fromAccount, fee);
-    }
+        await registry.sendCoins({ denom: DENOM, amount, destinationAddress: accounts[i].address }, fromAccount, fee);
+      }
+    });
 
-    await Promise.all(accounts.map((account) =>
-      registry.createBond({ denom: DENOM, amount: '100000' }, account.getPrivateKey(), fee)
-    ));
+    test('All txs get included in a single block.', async () => {
+      await Promise.all(accounts.map((account) =>
+        registry.createBond({ denom: DENOM, amount: '100000' }, account.getPrivateKey(), fee)
+      ));
 
-    const laconicClient = await registry.getLaconicClient(accounts[0]);
-    const bondTx = await laconicClient.searchTx('message.action="/cerc.bond.v1.MsgCreateBond"');
+      const laconicClient = await registry.getLaconicClient(accounts[0]);
+      const bondTx = await laconicClient.searchTx("message.action='/cerc.bond.v1.MsgCreateBond'");
 
-    const expectedBlockHeight = bondTx[0].height;
-    expect(bondTx.every(tx => tx.height === expectedBlockHeight)).toBe(true);
+      const expectedBlockHeight = bondTx[0].height;
+      expect(bondTx.every(tx => tx.height === expectedBlockHeight)).toBe(true);
+    });
   });
-
-  const createAccounts = async (numAccounts: number): Promise<Account[]> => {
-    const accounts: Account[] = [];
-
-    for (let i = 0; i < numAccounts; i++) {
-      const mnemonic = Account.generateMnemonic();
-      const account = await Account.generateFromMnemonic(mnemonic);
-      await account.init();
-      accounts.push(account);
-    }
-
-    return accounts;
-  };
 };
 
 describe('Registry', registryTests);
diff --git a/src/testing/helper.ts b/src/testing/helper.ts
index c431146..8c85652 100644
--- a/src/testing/helper.ts
+++ b/src/testing/helper.ts
@@ -2,7 +2,7 @@ import assert from 'assert';
 import yaml from 'node-yaml';
 import semver from 'semver';
 
-import { DEFAULT_CHAIN_ID } from '../index';
+import { Account, DEFAULT_CHAIN_ID } from '../index';
 
 export const ensureUpdatedConfig = async (path: string) => {
   const conf = await yaml.read(path);
@@ -33,3 +33,16 @@ export const getConfig = () => {
     }
   };
 };
+
+export const createTestAccounts = async (numAccounts: number): Promise<Account[]> => {
+  const accounts: Account[] = [];
+
+  for (let i = 0; i < numAccounts; i++) {
+    const mnemonic = Account.generateMnemonic();
+    const account = await Account.generateFromMnemonic(mnemonic);
+    await account.init();
+    accounts.push(account);
+  }
+
+  return accounts;
+};