From fb66b9aed5aba7ee842f00b426215d0623478dfd Mon Sep 17 00:00:00 2001 From: IshaVenikar Date: Fri, 13 Sep 2024 14:49:38 +0530 Subject: [PATCH] Fix lint issues --- gql/util.go | 3 ++- x/auction/keeper/keeper.go | 12 ++++++++---- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/gql/util.go b/gql/util.go index ba66c0180..f230f18e6 100644 --- a/gql/util.go +++ b/gql/util.go @@ -233,7 +233,8 @@ func GetGQLAuction(auction *auctiontypes.Auction, bids []*auctiontypes.Bid) (*Au } winnerAddresses := make([]*string, len(auction.WinnerAddresses)) - for i, addr := range auction.WinnerAddresses { + for i := range auction.WinnerAddresses { + addr := auction.WinnerAddresses[i] winnerAddresses[i] = &addr } diff --git a/x/auction/keeper/keeper.go b/x/auction/keeper/keeper.go index f7d04017e..a523f6370 100644 --- a/x/auction/keeper/keeper.go +++ b/x/auction/keeper/keeper.go @@ -16,7 +16,6 @@ import ( "cosmossdk.io/math" "github.com/cosmos/cosmos-sdk/codec" - "github.com/cosmos/cosmos-sdk/types" sdk "github.com/cosmos/cosmos-sdk/types" sdkerrors "github.com/cosmos/cosmos-sdk/types/errors" auth "github.com/cosmos/cosmos-sdk/x/auth/keeper" @@ -805,7 +804,7 @@ func (k Keeper) pickServiceProviderAuctionWinner(ctx sdk.Context, auction *aucti return err } - var revealedBids []*auctiontypes.Bid + revealedBids := make([]*auctiontypes.Bid, 0, len(bids)) for _, bid := range bids { k.Logger(ctx).Info(fmt.Sprintf("Processing bid %s %s", bid.BidderAddress, bid.BidAmount.String())) @@ -838,7 +837,7 @@ func (k Keeper) pickServiceProviderAuctionWinner(ctx sdk.Context, auction *aucti if len(winnerBids) > 0 { winnerAddresses := make([]string, len(winnerBids)) - winningBids := make([]types.Coin, len(winnerBids)) + winningBids := make([]sdk.Coin, len(winnerBids)) for i, bid := range winnerBids { winnerAddresses[i] = bid.BidderAddress winningBids[i] = bid.BidAmount @@ -904,7 +903,12 @@ func (k Keeper) pickServiceProviderAuctionWinner(ctx sdk.Context, auction *aucti extraAmountCoin := sdk.NewCoin(auction.MaxPrice.Denom, totalMaxBidAmount.Sub(totalAmountPaid)) - sdkErrCreator := k.bankKeeper.SendCoinsFromModuleToAccount(ctx, auctiontypes.ModuleName, sdk.AccAddress(auction.OwnerAddress), sdk.NewCoins(extraAmountCoin)) + sdkErrCreator := k.bankKeeper.SendCoinsFromModuleToAccount( + ctx, + auctiontypes.ModuleName, + sdk.AccAddress(auction.OwnerAddress), + sdk.NewCoins(extraAmountCoin), + ) if sdkErrCreator != nil { k.Logger(ctx).Error(fmt.Sprintf("Auction error returning bid amount: %v", sdkErrCreator)) panic(sdkErrCreator)