deep-stack/laconicd-deprecated
6
0
Fork 0
forked from cerc-io/laconicd-deprecated
Code Pull Requests Activity

rpc: personal_unpair (#733)

Browse Source 
* Problem: need to add rpc endpoint personal_unpair

Closes #730

* this is aimed at smartcard wallet which is not supported yet.

* will return unsupported error now.

* Update rpc/ethereum/namespaces/personal/api.go

* add changelog entry and use errors.Is

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
This commit is contained in:
Adu 2021-11-10 17:09:53 +08:00 committed by GitHub
parent d647988ad5
commit a3f1d8d89d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -49,6 +49,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (rpc) [tharsis#624](https://github.com/tharsis/ethermint/pull/624) Implement new JSON-RPC endpoints from latest geth version * (rpc) [tharsis#624](https://github.com/tharsis/ethermint/pull/624) Implement new JSON-RPC endpoints from latest geth version
* (evm) [tharsis#662](https://github.com/tharsis/ethermint/pull/662) Disable basefee for non london blocks * (evm) [tharsis#662](https://github.com/tharsis/ethermint/pull/662) Disable basefee for non london blocks
* (cmd) [tharsis#712](https://github.com/tharsis/ethermint/pull/712) add tx cli to build evm transaction * (cmd) [tharsis#712](https://github.com/tharsis/ethermint/pull/712) add tx cli to build evm transaction
* (rpc) [tharsis#733](https://github.com/tharsis/ethermint/pull/733) add JSON_RPC endpoint personal_unpair
### Bug Fixes ### Bug Fixes

8
rpc/ethereum/namespaces/personal/api.go
View File

@ -222,3 +222,11 @@ func (api *PrivateAccountAPI) EcRecover(_ context.Context, data, sig hexutil.Byt
return crypto.PubkeyToAddress(*pubkey), nil return crypto.PubkeyToAddress(*pubkey), nil
} }
// Unpair deletes a pairing between wallet and ethermint.
func (api *PrivateAccountAPI) Unpair(_ context.Context, url, pin string) error {
api.logger.Debug("personal_unpair", "url", url, "pin", pin)
api.logger.Info("personal_unpair for smartcard wallet not supported")
// TODO: Smartcard wallet not supported yet, refer to: https://github.com/ethereum/go-ethereum/blob/master/accounts/scwallet/README.md
return fmt.Errorf("smartcard wallet not supported yet")
}

12
tests/rpc/personal_test.go
View File

@ -2,6 +2,8 @@ package rpc
import ( import (
"encoding/json" "encoding/json"
"errors"
"fmt"
"testing" "testing"
"github.com/stretchr/testify/require" "github.com/stretchr/testify/require"
@ -142,3 +144,13 @@ func TestPersonal_LockAccount(t *testing.T) {
_, err = CallWithError("personal_sign", []interface{}{hexutil.Bytes{0x88}, addr, ""}) _, err = CallWithError("personal_sign", []interface{}{hexutil.Bytes{0x88}, addr, ""})
require.Error(t, err) require.Error(t, err)
} }
func TestPersonal_Unpair(t *testing.T) {
t.Skip("skipping TestPersonal_Unpair")
rpcRes := Call(t, "personal_unpair", []interface{}{"", 0})
var res error
err := json.Unmarshal(rpcRes.Result, &res)
require.True(t, errors.Is(err, fmt.Errorf("smartcard wallet not supported yet")))
}